Skip to content

Add metadata entry and config for new GPU Monitoring metrics - #25276

Open
steveny91 wants to merge 2 commits into
masterfrom
sy/roce-metadata-gpu-gated
Open

steveny91 wants to merge 2 commits into
masterfrom
sy/roce-metadata-gpu-gated

Conversation

@steveny91

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add the metadata and config entries to the network check. Related Go change:
DataDog/datadog-agent#56597

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests · passed

Dispatcher beta: informational only

Dispatcher is running alongside existing CI while we validate it. You can ignore this report and its statuses. Existing CI remains the merge signal.

  4/4 jobs
✅ 4 passed · ❌ 0 failed

Batches

BatchStateJobsWorkflow
batch-01✅ passed4/4run 35365488581
Dispatcher finished on 0952d3dGitHub Run.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (4 files):
  network/assets/configuration/spec.yaml
  network/changelog.d/25276.added
  network/datadog_checks/network/data/conf.yaml.default
  network/metadata.csv

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 18, 2026

Copy link
Copy Markdown

Tests  Code Coverage

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.38%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 89a4abe | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Disk usage change

Commit 89a4abe compared against 5329e6e.

Uncompressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +415 B 🔺 +415 B 🔺 +415 B 🔺 +415 B 🔺 +415 B
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
network 5.7.0 Integration 🔺 +415 B 🔺 +415 B 🔺 +415 B 🔺 +415 B 🔺 +415 B

Compressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +199 B 🔺 +199 B 🔺 +199 B 🔺 +199 B 🔺 +199 B
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
network 5.7.0 Integration 🔺 +199 B 🔺 +199 B 🔺 +199 B 🔺 +199 B 🔺 +199 B

@steveny91 steveny91 added the qa/skip-qa Automatically skip this PR for the next QA label Sep 18, 2026
@steveny91
steveny91 marked this pull request as ready for review September 18, 2026 15:32
@steveny91
steveny91 requested review from a team as code owners September 18, 2026 15:32
@steveny91
steveny91 requested a review from guohdd September 18, 2026 15:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62fd29794d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -0,0 +1 @@
Document the mlx5_core RoCE/PFC ethtool metrics collected when GPU monitoring is enabled: per-priority PFC counters tagged `prio:<0-7>`, link-level 802.3x pause counters, PCIe health, FEC and cable health, pause storm, and module health counters, plus the per-ring queue traffic metrics emitted alongside them.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the placeholder with the actual PR number

For any real PR number, the check_changelog workflow parses the fragment basename using int(entry_pr_num) in ddev/src/ddev/utils/scripts/check_pr.py, so the literal PR_NUMBER raises ValueError and prevents the required quick-check job from completing. Rename this fragment to <actual numeric PR number>.added after the PR is created.

AGENTS.md reference: AGENTS.md:L229-L232

Useful? React with 👍 / 👎.

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant