Skip to content

AI-6486 Make Dispatcher lifecycle logs distinguishable - #25272

Merged
AAraKKe merged 4 commits into
masterfrom
aarakke/AI-6486-readable-dispatcher-logs
Sep 24, 2026
Merged

AAraKKe merged 4 commits into
masterfrom
aarakke/AI-6486-readable-dispatcher-logs

Conversation

@AAraKKe

@AAraKKe AAraKKe commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Makes Dispatcher lifecycle messages identify their primary batch, workflow run, job, artifact, or report revision.

Adds a manifest-controlled console field policy so human-readable lines retain compact operational context without repeating large payloads such as the batch integration list. Structured Datadog logs keep native JSON values, including queryable integration arrays, and resolve the same batch context for runner and gatherer events.

Tests cover planned-batch lookup, unplanned messages, and aggregate reports at the scope boundary. A dispatcher wiring test verifies the context on actual dispatch and gatherer logs. A temporary scheduling probe confirmed this test passes with either progress or final results processed first; it does not require intermediate completion logs. The focused test selection passed (21 passed, 277 deselected), as did ddev --no-interactive test --lint ddev.

Motivation

Repeated messages such as Downloaded artifact and Job completed were difficult to distinguish in the GitHub Actions console. The integration list was also serialized as a string and only appeared during part of the batch lifecycle, which prevented direct membership queries across Dispatcher components.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts dd-octo-sts Bot added the ddev label Sep 18, 2026
@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Sep 18, 2026
@AAraKKe
AAraKKe force-pushed the aarakke/AI-6486-readable-dispatcher-logs branch from 8a9d227 to 899b45c Compare September 18, 2026 09:52
@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  855/855 jobs

✅ 855 passed · nothing failed

Batches · ✅ batch-01 240/240 · ✅ batch-02 217/217 · ✅ batch-03 220/220 · ✅ batch-04 178/178

Dispatcher finished on 20a3127 — GitHub Run · Dispatcher Logs.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   2 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Tests  Code Coverage

⚠️ Warnings

Your PR has warnings. Please review the issues below.

❄️ 1 New flaky test detected

test_batch_scoped_events_resolve_their_planned_batch_and_aggregates_stay_neutral from test_dispatcher.py
&#39;Job job-2 completed: success&#39;

View in Flaky Test Management

ℹ️ Info

No other issues found (see more)

🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 98.17%
• Overall Coverage: 89.35%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ffba288 | Docs | View more details | Give us feedback!

@AAraKKe
AAraKKe force-pushed the aarakke/AI-6486-readable-dispatcher-logs branch from 899b45c to 1107513 Compare September 21, 2026 07:10
@AAraKKe
AAraKKe marked this pull request as ready for review September 21, 2026 07:12
@AAraKKe
AAraKKe requested a review from a team as a code owner September 21, 2026 07:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T07:15:22.144404Z 1107513 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AAraKKe
AAraKKe force-pushed the aarakke/AI-6486-readable-dispatcher-logs branch from 1107513 to bb69f94 Compare September 21, 2026 09:26
HadhemiDD
HadhemiDD previously approved these changes Sep 21, 2026

@HadhemiDD HadhemiDD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@temporal-github-worker-1
temporal-github-worker-1 Bot dismissed HadhemiDD’s stale review September 23, 2026 12:13

Review from HadhemiDD is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/ci/dispatch_tests.py
    • ddev/src/ddev/cli/ci/tests/dispatcher_attributes.py
    • ddev/src/ddev/cli/ci/tests/task_run_reporter.py
    • ddev/src/ddev/monitoring/datadog.py
    • ddev/tests/cli/ci/test_dispatch_tests.py
    • ddev/tests/cli/ci/tests/test_dispatcher.py
    • ddev/tests/cli/ci/tests/test_dispatcher_attributes.py
    • ddev/tests/cli/ci/tests/test_task_run_reporter.py
    • ddev/tests/cli/ci/tests/test_task_test_gatherer.py
    • ddev/tests/monitoring/test_datadog.py
@AAraKKe
AAraKKe enabled auto-merge September 23, 2026 12:55
HadhemiDD
HadhemiDD previously approved these changes Sep 24, 2026
@temporal-github-worker-1
temporal-github-worker-1 Bot dismissed HadhemiDD’s stale review September 24, 2026 09:07

Review from HadhemiDD is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/ci/tests/dispatcher_logging.py
    • ddev/src/ddev/cli/ci/tests/task_run_reporter.py
    • ddev/tests/cli/ci/tests/test_dispatcher_logging.py
    • ddev/tests/cli/ci/tests/test_task_run_reporter.py
@AAraKKe
AAraKKe force-pushed the aarakke/AI-6486-readable-dispatcher-logs branch from aa92a0b to ffba288 Compare September 24, 2026 10:37
@dd-octo-sts

dd-octo-sts Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@AAraKKe
AAraKKe added this pull request to the merge queue Sep 24, 2026
Merged via the queue into master with commit d5f0018 Sep 24, 2026
388 of 390 checks passed
@AAraKKe
AAraKKe deleted the aarakke/AI-6486-readable-dispatcher-logs branch September 24, 2026 11:40
@dd-octo-sts dd-octo-sts Bot added this to the 7.85.0 milestone Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants