AI-6486 Make Dispatcher lifecycle logs distinguishable - #25272
Conversation
8a9d227 to
899b45c
Compare
✅ Dispatcher tests: passed
✅ 855 passed · nothing failed Batches · ✅ batch-01 240/240 · ✅ batch-02 217/217 · ✅ batch-03 220/220 · ✅ batch-04 178/178 Dispatcher finished on |
evalya-impact-summaryevalya impact analysis |
|
899b45c to
1107513
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1107513 to
bb69f94
Compare
Review from HadhemiDD is dismissed. Related teams and files:
- agent-integrations
- ddev/src/ddev/cli/ci/dispatch_tests.py
- ddev/src/ddev/cli/ci/tests/dispatcher_attributes.py
- ddev/src/ddev/cli/ci/tests/task_run_reporter.py
- ddev/src/ddev/monitoring/datadog.py
- ddev/tests/cli/ci/test_dispatch_tests.py
- ddev/tests/cli/ci/tests/test_dispatcher.py
- ddev/tests/cli/ci/tests/test_dispatcher_attributes.py
- ddev/tests/cli/ci/tests/test_task_run_reporter.py
- ddev/tests/cli/ci/tests/test_task_test_gatherer.py
- ddev/tests/monitoring/test_datadog.py
Review from HadhemiDD is dismissed. Related teams and files:
- agent-integrations
- ddev/src/ddev/cli/ci/tests/dispatcher_logging.py
- ddev/src/ddev/cli/ci/tests/task_run_reporter.py
- ddev/tests/cli/ci/tests/test_dispatcher_logging.py
- ddev/tests/cli/ci/tests/test_task_run_reporter.py
aa92a0b to
ffba288
Compare
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Makes Dispatcher lifecycle messages identify their primary batch, workflow run, job, artifact, or report revision.
Adds a manifest-controlled console field policy so human-readable lines retain compact operational context without repeating large payloads such as the batch integration list. Structured Datadog logs keep native JSON values, including queryable integration arrays, and resolve the same batch context for runner and gatherer events.
Tests cover planned-batch lookup, unplanned messages, and aggregate reports at the scope boundary. A dispatcher wiring test verifies the context on actual dispatch and gatherer logs. A temporary scheduling probe confirmed this test passes with either progress or final results processed first; it does not require intermediate completion logs. The focused test selection passed (
21 passed, 277 deselected), as didddev --no-interactive test --lint ddev.Motivation
Repeated messages such as
Downloaded artifactandJob completedwere difficult to distinguish in the GitHub Actions console. The integration list was also serialized as a string and only appeared during part of the batch lifecycle, which prevented direct membership queries across Dispatcher components.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged