Add StopFlowTool by luisorofino · Pull Request #25265 · DataDog/integrations-core

luisorofino · 2026-09-17T15:41:22Z

What does this PR do?

Adds a stop_flow tool for Togo agents. When a task is impossible as specified (e.g. the PRD requires connecting to an endpoint that doesn't exist), an agent calls stop_flow with a reason, and the whole run ends immediately with that reason recorded — instead of the agent guessing, improvising, or looping.

Mechanically: the tool just returns a ToolResult with stop_reason set. ReActProcess checks for it after each turn's tool calls and raises FlowStopRequested instead of feeding results back to the agent. From there it's the existing, unmodified failure path: the exception propagates out of the phase, Phase.on_error records a FailedCheckpoint with the agent's reason as the error, emits PhaseFailedMessage, and PhaseOrchestrator turns that into a FatalProcessingError that winds the whole bus down. No orchestrator or checkpoint changes were
needed — reusing the same cascade an unexpected phase failure already takes means a human can fix the PRD and rerun (the phase isn't checkpointed as successful, so it reruns), and the failure reason is exactly what the agent explained rather than a stack trace.

Motivation

Some Togo flows (future API-based flow) give agents instructions that can't always be satisfied (e.g. a generated PRD referencing something that doesn't exist). Previously an agent had no way to signal that cleanly — it would either fail with an opaque error or continue and produce a broken result. This gives it an explicit, self-explaining way to stop.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

cit-pr-commenter-54b7da · 2026-09-17T15:41:25Z

evalya-impact-summary

evalya impact analysis

Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (241 files):
  .gitignore
  ddev/hatch.toml
  ddev/pyproject.toml
  ddev/src/ddev/ai/__init__.py
  ddev/src/ddev/ai/agent/__init__.py
  ddev/src/ddev/ai/agent/anthropic_agent.py
  ddev/src/ddev/ai/agent/anthropic_provider.py
  ddev/src/ddev/ai/agent/base.py
  ddev/src/ddev/ai/agent/build.py
  ddev/src/ddev/ai/agent/exceptions.py
  ddev/src/ddev/ai/agent/provider.py
  ddev/src/ddev/ai/agent/registry.py
  ddev/src/ddev/ai/agent/scope.py
  ddev/src/ddev/ai/agent/types.py
  ddev/src/ddev/ai/callbacks/__init__.py
  ddev/src/ddev/ai/callbacks/callbacks.py
  ddev/src/ddev/ai/config/__init__.py
  ddev/src/ddev/ai/config/classify.py
  ddev/src/ddev/ai/config/dependency_graph.py
  ddev/src/ddev/ai/config/engine.py
  ... and 221 more

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

datadog-datadog-prod-us1-2 · 2026-09-17T16:03:24Z

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.84%

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9a96d46 | Docs | View more details | Give us feedback!}

luisorofino · 2026-09-18T08:06:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd5c0befcd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-18T08:11:12Z

+                    raise FlowStopRequested(
+                        f"Agent stopped the flow with reason:\n{stop_reason}",
+                        input_tokens=total_input,
+                        output_tokens=total_output,
+                    )


Let subagent stop requests escape the spawn wrappers

When a spawned child is granted stop_flow, this exception does not reach the phase: BaseSpawnTool._run_child catches every Exception and converts it into a ChildOutcome error, and the parallel spawn path also aggregates exceptions as ordinary child failures. The parent therefore continues even though the tool explicitly promises to stop the whole run, including from a subagent. Exempt FlowStopRequested from those wrappers and propagate it to the phase.

Useful? React with 👍 / 👎.

I did this on purpose. If a subagent wants to stop the pipeline, it executes the tool and the main agent decides whether the subagent's reason is fair enough to stop the whole flow. That way we don't give the subagent too much power. If the subagent's reason is strong, then the parent should stop.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2094346a60

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dd-octo-sts · 2026-09-18T10:30:59Z

Validation Report

All 21 validations passed.

Show details

Validation	Description	Status
`agent-reqs`	Verify check versions match the Agent requirements file	✅
`ci`	Validate CI configuration and code coverage settings	✅
`codeowners`	Validate every integration has a CODEOWNERS entry	✅
`config`	Validate default configuration files against spec.yaml	✅
`dep`	Verify dependency pins are consistent and Agent-compatible	✅
`http`	Validate integrations use the HTTP wrapper correctly	✅
`imports`	Validate check imports do not use deprecated modules	✅
`integration-style`	Validate check code style conventions	✅
`jmx-metrics`	Validate JMX metrics definition files and config	✅
`labeler`	Validate PR labeler config matches integration directories	✅
`legacy-signature`	Validate no integration uses the legacy Agent check signature	✅
`license-headers`	Validate Python files have proper license headers	✅
`licenses`	Validate third-party license attribution list	✅
`metadata`	Validate metadata.csv metric definitions	✅
`models`	Validate configuration data models match spec.yaml	✅
`openmetrics`	Validate OpenMetrics integrations disable the metric limit	✅
`package`	Validate Python package metadata and naming	✅
`qa-label`	Validate the pull request declares whether it needs QA for the next Agent release	✅
`readmes`	Validate README files have required sections	✅
`saved-views`	Validate saved view JSON file structure and fields	✅
`version`	Validate version consistency between package and changelog	✅

View full run

luisorofino added the qa/skip-qa Automatically skip this PR for the next QA label Sep 17, 2026

dd-octo-sts Bot added the ddev label Sep 17, 2026

chatgpt-codex-connector Bot reviewed Sep 18, 2026

View reviewed changes

luisorofino marked this pull request as ready for review September 18, 2026 08:48

luisorofino requested a review from a team as a code owner September 18, 2026 08:48

dd-octo-sts Bot added the team/agent-integrations label Sep 18, 2026

chatgpt-codex-connector Bot reviewed Sep 18, 2026

View reviewed changes

Comment thread ddev/src/ddev/ai/phases/goal.py

Comment thread ddev/src/ddev/ai/react/process.py

luisorofino added 6 commits September 18, 2026 12:29

Add StopFlowTool

e2ad3cf

Record tokens when stopping flow

93656e5

Ensure we always count tokens when stopping, even in goal reviews

f560600

Check for checkpoints in the test

554d45f

Count tokens when subagent stops the flow

a3ea9aa

Count tokens when reviewer agent retries the response and stops the flow

9a96d46

luisorofino force-pushed the loa/stop-flow-tool branch from a3325ea to 9a96d46 Compare September 18, 2026 10:29

luisorofino marked this pull request as draft September 18, 2026 14:41

Navigation Menu

Add StopFlowTool - #25265

Add StopFlowTool#25265
luisorofino wants to merge 6 commits into
loa/openmetrics-ai-genfrom
loa/stop-flow-tool

luisorofino commented Sep 17, 2026 •

edited

Loading

Uh oh!

cit-pr-commenter-54b7da Bot commented Sep 17, 2026

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

luisorofino commented Sep 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 18, 2026

Uh oh!

luisorofino Sep 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

luisorofino commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

cit-pr-commenter-54b7da Bot commented Sep 17, 2026

evalya-impact-summary

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luisorofino commented Sep 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

luisorofino Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Sep 18, 2026

Validation Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

luisorofino commented Sep 17, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Sep 17, 2026 •

edited

Loading

luisorofino Sep 18, 2026 •

edited

Loading