Report unreachable OpenMetrics endpoints to Agent Health - #25248
Draft
mwdd146980 wants to merge 14 commits into
Draft
mwdd146980 wants to merge 14 commits into
mwdd146980 wants to merge 14 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
✅ Dispatcher tests · passed
Batches
3aa766c — GitHub Run.
|
evalya-impact-summaryevalya impact analysis |
Contributor
Disk usage changeCommit Uncompressed
Details
Compressed
Details
|
Contributor
🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: c7e2073 | Docs | View more details | Give us feedback! |
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reports an
OpenMetrics Endpoint UnreachableAgent Health issue when an OpenMetrics v1 or v2 scrape fails withEHOSTUNREACH(No route to host). Envoy is covered automatically throughOpenMetricsBaseCheckV2.The issue includes a sanitized endpoint and network-focused remediation. It uses a stable per-endpoint ID and resolves when the endpoint becomes reachable, is removed during a dynamic refresh, or its configuration is unscheduled. Existing check errors and health service checks remain unchanged. Other connectivity failures are not reported. Reporting is best-effort and uses the existing
AgentCheck.report_issuebridge, so no Agent or rtloader changes are required.Motivation
This error occurs frequently in staging for OpenMetrics and Envoy (link to FA, link to logs):
There was an error scraping endpoint <endpoint>: HTTPConnectionPool(...): Failed to establish a new connection: [Errno 113] No route to hostI figured fixing this for own our org would be a good motivation for reporting from integrations to Agent Health.