Skip to content

Restore Dynamo manifest - #25244

Open
piochelepiotr wants to merge 3 commits into
masterfrom
pw/restore-dynamo-manifest
Open

piochelepiotr wants to merge 3 commits into
masterfrom
pw/restore-dynamo-manifest

Conversation

@piochelepiotr

Copy link
Copy Markdown
Contributor

What does this PR do?

Restores the Dynamo integration manifest, dataflow metadata, and image directory placeholder that were removed for the publishing-platform workflow. Removes the temporary manifestless overrides from .ddev/config.toml.

Motivation

The publishing platform no longer plans to manage internally built integrations, so Dynamo needs to return to the repository-managed manifest workflow.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@piochelepiotr piochelepiotr added the qa/skip-qa Automatically skip this PR for the next QA label Sep 16, 2026
@dd-octo-sts dd-octo-sts Bot added documentation integration/dynamo and removed qa/skip-qa Automatically skip this PR for the next QA labels Sep 16, 2026
@piochelepiotr
piochelepiotr force-pushed the pw/restore-dynamo-manifest branch from 6e27900 to 9c6cef3 Compare September 16, 2026 14:09
@piochelepiotr piochelepiotr added the qa/skip-qa Automatically skip this PR for the next QA label Sep 16, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 16, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (4 files):
  .ddev/config.toml
  dynamo/assets/dataflows.yaml
  dynamo/images/.gitkeep
  dynamo/manifest.json

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@dd-octo-sts

dd-octo-sts Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Disk usage change

Commit 6e27900 compared against 9c164f9.

No integration or dependency changed size.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0bcb737eb7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread dynamo/manifest.json
Comment on lines +1 to +2
{
"manifest_version": "2.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the new Dynamo integration manifestless

Dynamo was introduced in commit 03203e64 without a manifest, so it does not qualify for the exemption for existing integrations that already have one. Adding this file and removing Dynamo's display-name, metrics-prefix, and platform overrides puts the newly created integration back onto the prohibited legacy manifest workflow; retain the three overrides and omit the manifest instead.

AGENTS.md reference: AGENTS.md:L105-L113

Useful? React with 👍 / 👎.

@dd-octo-sts

dd-octo-sts Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants