Skip to content

[AI-7174] Remove manifest-less args from ddev create tool - #25221

Merged
luisorofino merged 2 commits into
loa/openmetrics-ai-genfrom
loa/restore-ddev-create-tool
Sep 21, 2026
Merged

luisorofino merged 2 commits into
loa/openmetrics-ai-genfrom
loa/restore-ddev-create-tool

Conversation

@luisorofino

@luisorofino luisorofino commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove the manifest-less args from the ddev_create tool in Togo.

The tool's integration input now carries the display name straight through to ddev create: the command itself normalizes it to snake_case for the directory, Python package, and metrics prefix, while preserving the display name verbatim in the manifest's display-name fields. That behavior is documented on the tool's input field so any flow using the tool gets it for free, instead of every flow having to know to skip pre-normalizing the name before scaffolding.

Motivation

New integrations restore the manifest.json file, and ddev create command has changed in #25218, so we need to update the tool here as well.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@luisorofino luisorofino added the qa/skip-qa Automatically skip this PR for the next QA label Sep 15, 2026
@dd-octo-sts dd-octo-sts Bot added the ddev label Sep 15, 2026
@luisorofino
luisorofino marked this pull request as ready for review September 15, 2026 10:57
@luisorofino
luisorofino requested a review from a team as a code owner September 15, 2026 10:57
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 15, 2026

Copy link
Copy Markdown

Tests  Code Coverage

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 89.82%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bee74d7 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 15, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (239 files):
  .gitignore
  ddev/hatch.toml
  ddev/pyproject.toml
  ddev/src/ddev/ai/__init__.py
  ddev/src/ddev/ai/agent/__init__.py
  ddev/src/ddev/ai/agent/anthropic_agent.py
  ddev/src/ddev/ai/agent/anthropic_provider.py
  ddev/src/ddev/ai/agent/base.py
  ddev/src/ddev/ai/agent/build.py
  ddev/src/ddev/ai/agent/exceptions.py
  ddev/src/ddev/ai/agent/provider.py
  ddev/src/ddev/ai/agent/registry.py
  ddev/src/ddev/ai/agent/scope.py
  ddev/src/ddev/ai/agent/types.py
  ddev/src/ddev/ai/callbacks/__init__.py
  ddev/src/ddev/ai/callbacks/callbacks.py
  ddev/src/ddev/ai/config/__init__.py
  ddev/src/ddev/ai/config/classify.py
  ddev/src/ddev/ai/config/dependency_graph.py
  ddev/src/ddev/ai/config/engine.py
  ... and 219 more

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 385af22998

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ddev/src/ddev/ai/tools/shell/ddev/create.py
Comment thread ddev/src/ddev/ai/tools/shell/ddev/create.py Outdated
@luisorofino
luisorofino force-pushed the loa/restore-ddev-create-tool branch from 385af22 to bff624f Compare September 15, 2026 11:08
@luisorofino luisorofino changed the title Remove manifest-less args from ddev create tool [AI-7174] Remove manifest-less args from ddev create tool Sep 15, 2026
@luisorofino
luisorofino marked this pull request as draft September 18, 2026 14:42
@luisorofino
luisorofino marked this pull request as ready for review September 21, 2026 10:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bff624f0df

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ddev/src/ddev/ai/tools/shell/ddev/create.py Outdated
ddev create now normalizes the raw display name it is given to
snake_case for the directory/package/metrics prefix while keeping the
display name verbatim in the manifest. Pass the display name straight
through the ddev_create tool instead of pre-normalizing it in flow
prompts, and describe that behavior on the tool's input field so every
flow gets it for free.
@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@luisorofino
luisorofino merged commit 9477f7a into loa/openmetrics-ai-gen Sep 21, 2026
358 checks passed
@luisorofino
luisorofino deleted the loa/restore-ddev-create-tool branch September 21, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants