Repository navigation
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9854ee2840
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: gitlab_url | ||
| fleet_configurable: true | ||
| formats: ["url"] | ||
| formats: ["secret"] |
There was a problem hiding this comment.
Use
secret field instead of unsupported format
Changing gitlab_url to formats: ["secret"] makes the config spec invalid: the config validator only accepts java_jvm_options, path, port, and url in formats (datadog_checks_dev/datadog_checks/dev/tooling/configuration/constants.py, ALLOWED_FORMATS), and formats_validator rejects unknown entries (.../spec.py). This will fail config-spec validation for this integration; if the goal is to mark this value sensitive, use the option-level secret: true flag and keep URL formatting metadata separate.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged