test: pin appsec's nightly toolchain - #4212
morrisonlevi wants to merge 2 commits into
Conversation
Version 2025-10-31 is near 1.91.1 and is the same version used elsewhere in our images.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3eb6a17 | Docs | View more details | Give us feedback! |
|
IIRC nightly is only to rebuild std. Can't we use stable for building, but set RUSTC_BOOTSTRAP=1? That way we wouldn't even need to install the nightly toolchain. |
Description
When I rebuilt these images this week, I didn't realize they were going to pick up an unpinned nightly. It's not a "problem" per-se, but it does create a bunch of warnings in the logs, such as this one in
helper-rust integration coverage:But it's not actionable, as
.try_updatedoesn't stabilize until1.99and our MSRV is only1.91.Version
2025-10-31is near1.91.1and is the same version used elsewhere in our images. Pinning it removes a bunch of warnings.Reviewer checklist