Skip to content

test: exempt known broken AppSec musl ZTS releases - #4207

Open
morrisonlevi wants to merge 1 commit into
masterfrom
levi/installer-musl-zts-release-exceptions
Open

morrisonlevi wants to merge 1 commit into
masterfrom
levi/installer-musl-zts-release-exceptions

Conversation

@morrisonlevi

Copy link
Copy Markdown
Collaborator

Description

The appsec installer tests will forever fail on Alpine ZTS releases for 1.25.x because they have a dependency on __cxa_thread_atexit_impl which is not provided. Skip them so we don't fail them in every PR until 1.25.2 or 1.26.0 are made.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi
morrisonlevi requested review from a team as code owners September 17, 2026 00:06
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 17, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [7.4, arm64] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | Loader test on arm64 libc: [8.1, nts, arm64] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | check libxml2 version — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 66.73% (-0.07%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a84efd7 | Docs | View more details | Give us feedback!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T00:08:40.474357Z a84efd7 PR opened
🔒 Security Review Completed 2026-09-17T00:12:14.768777Z a84efd7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cataphract cataphract left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But why are we running tests against releases on every commit?

@morrisonlevi

Copy link
Copy Markdown
Collaborator Author

I had the same question! What this is really testing is that the datadog-setup.php script can actually work with GitHub artifacts, which we obviously don't have for the current release. I had to ask Bob about this. Bob thinks that the fix should go a different way but he said it would be easier to open a PR than to explain it. So I am awaiting that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants