chore(agents): add verbatim dd-apm-sdk-review skill copy by robertomonteromiguel · Pull Request #4190 · DataDog/dd-trace-php

robertomonteromiguel · 2026-09-14T14:49:03Z

What does this PR do?

Adds a verbatim copy of the shared dd-apm-sdk-review skill so local agents can load it from disk.

Source of truth: dd-apm-sdk-review-core#1 (56f6341)
Files: .agents/skills/dd-apm-sdk-review/ plus Claude/Cursor skill links
This repo had no agent skills yet
CODEOWNERS: no extra rule — the catch-all * @DataDog/apm-php @DataDog/apm-php-core already covers .agents/

This is PR 1 of 2. PHP-specific overrides, AGENTS.md, and the eval gate land in the follow-up stacked on this branch.

Motivation

Same split as the other tracers: PHP reviewers should not be asked to read the shared skill copy. Repo-owned rules live in the stacked PR.

Additional Notes

How to review

Do not review the markdown under .agents/skills/dd-apm-sdk-review/. That is a mirror of dd-apm-sdk-review-core#1.
Review here: confirm there is no product / extension code, and that CODEOWNERS already covers the new tree.
Edits to the skill belong in the core repo, not this one.

Do not merge this PR on its own — land it with the overrides follow-up.

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

Made with Cursor

Mirror dd-apm-sdk-review-core 56f6341 under .agents/skills and expose it to Claude/Cursor via symlinks. Co-authored-by: Cursor <cursoragent@cursor.com>

datadog-datadog-prod-us1-2 · 2026-09-14T14:56:19Z

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 15 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Loader test on arm64 libc: [7.2, nts] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | check libxml2 version — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | framework test: [flow_no_ddtrace] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 15 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 55.06% (+0.03%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c3d52cd | Docs | View more details | Give us feedback!}

robertomonteromiguel · 2026-09-14T16:22:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f4f30d666

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Drop the security lens; local review is on-demand.

robertomonteromiguel · 2026-09-15T15:45:07Z

@codex review

chatgpt-codex-connector · 2026-09-15T15:48:15Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 7c119f63b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

robertomonteromiguel · 2026-09-15T16:14:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe32d02f18

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

pr-commenter · 2026-09-15T17:36:00Z

Benchmarks [ tracer ]

Benchmark execution time: 2026-09-16 09:35:45

Comparing candidate commit c3d52cd in PR branch robertomonteromiguel/dd-apm-sdk-review-core-copy with baseline commit d1cbedb in branch master.

Found 1 performance improvements and 3 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟩 execution_time [-5.806µs; -3.454µs] or [-5.168%; -3.074%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

🟥 execution_time [+94.774ns; +183.026ns] or [+6.538%; +12.627%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+74.168ns; +184.432ns] or [+4.994%; +12.418%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

🟥 execution_time [+74.066ns; +170.334ns] or [+5.044%; +11.599%]

First-parent stacked parent, Cross-SDK system-tests/docs evidence.

robertomonteromiguel · 2026-09-16T08:27:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3d52cd0a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3d52cd0a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-16T16:06:17Z

+    if [ "$_ahead" -lt "$_default_ahead" ]; then
+      if [ -z "$_best_ahead" ] || [ "$_ahead" -lt "$_best_ahead" ]; then
+        _best_ahead=$_ahead
+        _best_oid=$_oid
+        _best_name=$_name


Confirm inferred stacked parents before truncating the diff

When a no-PR branch has any differently named local or DataDog-remote branch pointing at an intermediate first-parent commit—for example, a leftover scratch branch—this loop selects that ref solely because it is closer than the default branch. infer_local_target then reviews only the commits after that ref, silently omitting earlier commits from the change set; the later “ask if it looks wrong” message does not pause the review. Require confirmation before using an inferred parent, or limit candidates to refs with stronger evidence that they are the intended stack base.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-16T16:06:17Z

+
+emit_diff_or_redact "PR title" printf '%s\n' "PR title: ${PR_TITLE:-<none>}"
+emit_diff_or_redact "PR labels" printf '%s\n' "PR labels: ${PR_LABELS:-<none>}"
+emit_diff_or_redact "recent commit subjects" git log --oneline -5


Collect subjects from the actual review range

For any change whose committed range is not exactly the last five commits, this supplies the wrong metadata: older in-range subjects are omitted, while a shorter or stacked change includes subjects from its parent branch. Because the coherence lens explicitly checks commit-message claims against the diff, it can consequently miss contradictions or report an unrelated parent commit. Resolve the merge base first and scan git log --oneline "$BASE"..HEAD instead.

Useful? React with 👍 / 👎.

chore(agents): add verbatim dd-apm-sdk-review skill copy

5f4f30d

Mirror dd-apm-sdk-review-core 56f6341 under .agents/skills and expose it to Claude/Cursor via symlinks. Co-authored-by: Cursor <cursoragent@cursor.com>

robertomonteromiguel mentioned this pull request Sep 14, 2026

chore(agents): add starter dd-trace-php overrides for dd-apm-sdk-review #4191

Draft

2 tasks

robertomonteromiguel added the cat:docs label Sep 14, 2026

chatgpt-codex-connector Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md Outdated

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md Outdated

chore(agents): sync dd-apm-sdk-review from core 97d8bc1

7c119f6

Drop the security lens; local review is on-demand.

chore(agents): sync dd-apm-sdk-review from core 5b5b08d

fe32d02

chatgpt-codex-connector Bot reviewed Sep 15, 2026

View reviewed changes

chore(agents): sync dd-apm-sdk-review from core 749ff7a

c3d52cd

First-parent stacked parent, Cross-SDK system-tests/docs evidence.

chatgpt-codex-connector Bot reviewed Sep 16, 2026

View reviewed changes

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md

Comment thread .agents/skills/dd-apm-sdk-review/SKILL.md

robertomonteromiguel marked this pull request as ready for review September 16, 2026 15:59

robertomonteromiguel requested review from a team as code owners September 16, 2026 15:59

chatgpt-codex-connector Bot reviewed Sep 16, 2026

View reviewed changes

robertomonteromiguel marked this pull request as draft September 18, 2026 15:10

Conversation

robertomonteromiguel commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Reviewer checklist

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Sep 14, 2026 • edited by datadog-prod-us1-6 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Errors

ℹ️ Info

Uh oh!

robertomonteromiguel commented Sep 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertomonteromiguel commented Sep 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 15, 2026

Uh oh!

robertomonteromiguel commented Sep 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pr-commenter Bot commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

Explanation

More details about the CI and significant changes

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching1

scenario:SamplingRuleMatchingBench/benchRegexMatching2

scenario:SamplingRuleMatchingBench/benchRegexMatching3

Uh oh!

robertomonteromiguel commented Sep 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

robertomonteromiguel commented Sep 14, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Sep 14, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

pr-commenter Bot commented Sep 15, 2026 •

edited

Loading