Skip to content

Disable Exception Replay for JDK < 11 - #12411

Open
jpbempel wants to merge 3 commits into
masterfrom
jpbempel/disable-er-jdk8
Open

Disable Exception Replay for JDK < 11#12411
jpbempel wants to merge 3 commits into
masterfrom
jpbempel/disable-er-jdk8

Conversation

@jpbempel

@jpbempel jpbempel commented Sep 4, 2026

Copy link
Copy Markdown
Member

What Does This Do

Due to elusive JVM bug in JDK 8 we are preventing to enable remotely Exception Replay to avoid having crashes or NegativeArraySizeException

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel
jpbempel requested a review from a team as a code owner September 4, 2026 15:07
@jpbempel
jpbempel requested review from ojung and removed request for a team September 4, 2026 15:07
@jpbempel jpbempel added the type: bug fix Bug fix label Sep 4, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Sep 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01e7adb66b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-prod-us1-3 datadog-prod-us1-3 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

On Java 8, the new gate also blocks a remote stop request. Exception Replay can stay active after remote configuration disables it.

Open Bits AI session

🤖 Datadog Autotest · Commit 01e7adb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 4, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 75.00%
Overall Coverage: 74.31% (+15.26%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5d5cd92 | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 4, 2026

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1788547192 1788547519
end_time 2026-09-04T18:41:23 2026-09-04T18:46:50
git_branch master jpbempel/disable-er-jdk8
git_commit_sha 71faaaa 5d5cd92
start_time 2026-09-04T18:39:53 2026-09-04T18:45:20
See matching parameters
Baseline Candidate
ci_job_id 2017288749 2017288749
ci_pipeline_id 135571564 135571564
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
git_commit_date 1788546565 1788546565

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.460µs; +31.105µs] or [-8.225%; +9.317%]
unstable
[-41093.573ns; +41038.496ns] or [-11.145%; +11.130%]
unstable
[-51729.329ns; +50256.109ns] or [-13.471%; +13.088%]
unstable
[-119.866µs; +77.489µs] or [-9.978%; +6.451%]
same
scenario:basic same same same unstable
[-79.220µs; +181.959µs] or [-7.802%; +17.919%]
unstable
[-141.260op/s; +141.260op/s] or [-6.357%; +6.357%]
scenario:loop same same same same same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (368.706 µs) : 331, 407
.   : milestone, 369,
basic (343.677 µs) : 336, 351
.   : milestone, 344,
loop (8.11 ms) : 8046, 8174
.   : milestone, 8110,
section candidate
noprobe (368.679 µs) : 329, 409
.   : milestone, 369,
basic (340.864 µs) : 334, 348
.   : milestone, 341,
loop (8.113 ms) : 8049, 8177
.   : milestone, 8113,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 368.706 µs [330.747 µs, 406.666 µs]
basic 343.677 µs [336.078 µs, 351.276 µs]
loop 8.11 ms [8.046 ms, 8.174 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 368.679 µs [328.688 µs, 408.669 µs]
basic 340.864 µs [333.64 µs, 348.088 µs]
loop 8.113 ms [8.049 ms, 8.177 ms]

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.81 s 14.74 s [-0.7%; +1.7%] (no difference)
startup:insecure-bank:tracing:Agent 13.59 s 13.68 s [-1.4%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.59 s 17.12 s [+1.9%; +3.5%] (significantly worse)
startup:petclinic:iast:Agent 17.46 s 17.61 s [-1.6%; -0.1%] (maybe better)
startup:petclinic:profiling:Agent 17.32 s 17.54 s [-2.5%; -0.0%] (maybe better)
startup:petclinic:sca:Agent 17.56 s 17.45 s [-0.2%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 16.62 s 16.62 s [-1.3%; +1.2%] (no difference)

Commit: 5d5cd928 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Due to elusive JVM bug in JDK 8 we are preventing to enable remotely
Exception Replay to avoid having crashes or NegativeArraySizeException
@jpbempel
jpbempel force-pushed the jpbempel/disable-er-jdk8 branch from a3d86dc to 5d5cd92 Compare September 4, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants