Disable Exception Replay for JDK < 11 - #12411
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01e7adb66b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
On Java 8, the new gate also blocks a remote stop request. Exception Replay can stay active after remote configuration disables it.
🤖 Datadog Autotest · Commit 01e7adb · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5d5cd92 | Docs | View more details | Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (368.706 µs) : 331, 407
. : milestone, 369,
basic (343.677 µs) : 336, 351
. : milestone, 344,
loop (8.11 ms) : 8046, 8174
. : milestone, 8110,
section candidate
noprobe (368.679 µs) : 329, 409
. : milestone, 369,
basic (340.864 µs) : 334, 348
. : milestone, 341,
loop (8.113 ms) : 8049, 8177
. : milestone, 8113,
|
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Due to elusive JVM bug in JDK 8 we are preventing to enable remotely Exception Replay to avoid having crashes or NegativeArraySizeException
a3d86dc to
5d5cd92
Compare
What Does This Do
Due to elusive JVM bug in JDK 8 we are preventing to enable remotely Exception Replay to avoid having crashes or NegativeArraySizeException
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]