Use ConcurrentHashtable for telemetry log deduplication - #12367
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1367128 to
c1af819
Compare
What Does This Do
Replaces LogCollector's ConcurrentHashMap dedup storage with a bounded ConcurrentHashtable entry that carries its own atomic count. Duplicate lookups no longer construct RawLogMessage.
Migrates the direct tests to JUnit 5 and strengthens concurrency, capacity, and drain coverage.
Motivation
Telemetry logging can be reached repeatedly from error paths. The previous duplicate-hit path allocated a RawLogMessage on every call and retained a separate AtomicInteger per distinct message.
Additional Notes
Stacked on #11675.
The eight-thread duplicate-hit benchmark reduced normalized allocation from 48.000 B/op to approximately 0 B/op (about 1e-4 B/op measured).
Contributor Checklist