Skip to content

Fix StringIndexOutOfBoundsException parsing JTDS JDBC URLs without a database segment #12227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dougqh wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix StringIndexOutOfBoundsException parsing JTDS JDBC URLs without a database segment #12227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d24ab96
Fix StringIndexOutOfBoundsException parsing JTDS URLs without a datab…
dougqh Aug 17, 2026
ee9d285
Fix spotless formatting in JDBCConnectionUrlParser
dougqh Aug 17, 2026
e6caa97
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
dougqh Aug 21, 2026
a3efa6f
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
dougqh Aug 28, 2026
601e861
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
dougqh Sep 2, 2026
1a8c4c2
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
dougqh Sep 2, 2026
b86e36d
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
bric3 Sep 4, 2026
23e3f34
Merge branch 'master' into dougqh/fix-jtds-jdbc-url-port-parsing
dougqh Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...p/src/main/java/datadog/trace/bootstrap/instrumentation/jdbc/JDBCConnectionUrlParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,9 @@ DBInfo.Builder doParse(final String jdbcUrl, final DBInfo.Builder builder) {

if (portLoc > 0) {
hostEndLoc = portLoc;
final int portEndLoc = dbLoc > 0 ? dbLoc : (paramLoc > 0 ? paramLoc : details.length());
try {
builder.port(Integer.parseInt(details.substring(portLoc + 1, dbLoc)));
builder.port(Integer.parseInt(details.substring(portLoc + 1, portEndLoc)));
} catch (final NumberFormatException ignored) {
}
} else if (dbLoc > 0) {
Expand Down
3 changes: 3 additions & 0 deletions dd-java-agent/instrumentation/jdbc/src/test/groovy/JDBCConnectionUrlParserTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ class JDBCConnectionUrlParserTest extends InstrumentationSpecification {
"jdbc:jtds:sqlserver://dbhostname.com;user=user;password=pw" | null | "jtds" | "sqlserver" | "user" | "dbhostname.com" | 1433 | null | null
"jdbc:jtds:sqlserver://dbhostname.com" | null | "jtds" | "sqlserver" | null | "dbhostname.com" | 1433 | null | null
"jdbc:jtds:sybase://dbhostname.com" | null | "jtds" | "sybase" | null | "dbhostname.com" | 7100 | null | null
// host:port with no trailing '/db' and no ';' params (regression: StringIndexOutOfBoundsException)
"jdbc:jtds:sqlserver://dbhostname.com:1433" | null | "jtds" | "sqlserver" | null | "dbhostname.com" | 1433 | null | null
"jdbc:jtds:sqlserver://dbhostname.com:1433;user=user;password=pw" | null | "jtds" | "sqlserver" | "user" | "dbhostname.com" | 1433 | null | null

// redshift
"jdbc:redshift://redshift-cluster-1.c7arcolffyvk.us-east-2.redshift.amazonaws.com:5439/dev" | null | "redshift" | null | null | "redshift-cluster-1.c7arcolffyvk.us-east-2.redshift.amazonaws.com" | 5439 | "redshift-cluster-1" | "dev"
Expand Down