[reference] reactor-core-3.1 async blind regeneration for #11927#11940
[reference] reactor-core-3.1 async blind regeneration for #11927#11940jordan-wong wants to merge 1 commit into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: dbf3d6b | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
…skill Automated integration-authoring pass on reactor-core-3.1, produced against the draft skill in #11927. Reference for #11927 reviewers to see concrete output the current skill draft produces. Not intended to be merged as-is. Base: master @ 05671ce (rebased from original 2e1d2b9; the original branch inherited a stash-merge revert of #11852 during eval branch setup that dropped DD_TRACE_ROBOLECTRIC_ENABLED from metadata plus 172 unrelated files. This rebased version cherry-picks ONLY the reactor-core-3.1 module output onto current master, preserving all unrelated upstream changes.) Cost: \$13, reviewer approved with 0 todos remaining. Diff scope: dd-java-agent/instrumentation/reactor-core-3.1/ only. Metadata: no change (all reactor entries already present on master). Note: the toolkit reorganized the package layout from 'datadog.trace.instrumentation.reactor.core' (master) to 'datadog.trace.instrumentation.reactorcore' (eval). This is a regen-preservation Rule #2 concern; documented for reviewer consideration.
2e1d2b9 to
dbf3d6b
Compare
|
Rebased 2026-07-14 — branch force-pushed onto current master to fix the shared Root cause (not a toolkit bug): the original eval branch inherited a stash-merge revert of #11852 during branch setup. See #11939 comment for the full diagnostic. Fix: cherry-picked only the in-scope Result: 24 files changed (all under Note for reviewers: the eval reorganized the package layout from Original commit: The 10 CI failures beyond the shared metadata bug are being triaged separately. |
Reference draft for the skill PR #11927. This diff is the output of an automated integration-authoring pass on
reactor-core-3.1(Cat B — context propagation) against the draft skill in that PR. Not intended to be merged as-is — opened so reviewers of #11927 can see concrete output the current skill draft produces.What this is
Master's
reactor-core-3.1module was deleted, then the automated authoring flow was run against the draft skill in #11927 (the F2/S1/CI-1 rules were in-tree on the target checkout at generation time). This branch is the resulting output.Base:
origin/masterScope: 25 files, +994/-2741 — only inside
dd-java-agent/instrumentation/reactor-core-3.1/and one entry inmetadata/supported-configurations.json.Generation metrics
Notably smoother than the rxjava-3.0 companion run (~3.5h, $43, 4 test-fix iterations). Possible reasons: fewer types to instrument (Flux + Mono vs 6 rxjava types); or the current skill draft happens to guide reactor-shaped code more directly. Reviewers may find this an interesting data point.
What to look at
ReactorCoreModule.java: does it extendInstrumenterModule.ContextTracking(correct for Cat B)?super(...): single-name pattern per the F2 rule in skill(apm-integrations): additional rules from recent HTTP-category PR reviews #11927FluxInstrumentation.java,MonoInstrumentation.java: should contain NO span-lifecycle symbols (startSpan,activateSpan,AgentSpan,AgentScope,Decorator)TracingCoreSubscriber.java: the wrapper class that attachesContext.current()at the async boundarycontextStore()map on the ModuleAsyncPropagatingDisableInstrumentationinjava-concurrent-1.8/for Reactor'sSchedulers.parallel()thread poolNot for merging
This branch is a reference artifact for the skill PR discussion. The shipping
reactor-core-3.1on master is the authoritative implementation.🤖 Generated with APM Instrumentation Toolkit