Add offline Feature Flagging reference implementation#11933
Draft
leoromanovsky wants to merge 1 commit into
Draft
Add offline Feature Flagging reference implementation#11933leoromanovsky wants to merge 1 commit into
leoromanovsky wants to merge 1 commit into
Conversation
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: 8d654e2 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Provide a small Java reference implementation for the startup-only offline Feature Flagging mode so the cross-SDK system-test contract can be exercised before the production implementation is reviewed. This draft is stacked on #11892 and intentionally keeps the offline API narrow: the application supplies complete UFC JSON bytes once at provider initialization.
Changes
Provider.Options.offlineConfiguration(byte[])ServerConfigurationmodelDecisions
Validation
./gradlew :products:feature-flagging:feature-flagging-bootstrap:spotlessCheck :products:feature-flagging:feature-flagging-lib:spotlessCheck :products:feature-flagging:feature-flagging-api:spotlessCheck :products:feature-flagging:feature-flagging-agent:spotlessCheck./gradlew :products:feature-flagging:feature-flagging-bootstrap:test :products:feature-flagging:feature-flagging-lib:test :products:feature-flagging:feature-flagging-api:test :products:feature-flagging:feature-flagging-agent:test—BUILD SUCCESSFUL./gradlew :dd-java-agent:shadowJar :dd-trace-api:jar :products:feature-flagging:feature-flagging-api:jar—BUILD SUCCESSFULsystem-tests, and force-ran the disabled offline contract:26 passed in 37.82sCompanion system-tests draft: DataDog/system-tests#7305.