Repository navigation
Use quotes for system tests refs - #10998
Conversation
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the follow up PR
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071449
Total [baseline] (11.076 s) : 0, 11075564
Agent [candidate] (1.067 s) : 0, 1066527
Total [candidate] (11.12 s) : 0, 11119832
section appsec
Agent [baseline] (1.249 s) : 0, 1248800
Total [baseline] (11.193 s) : 0, 11193147
Agent [candidate] (1.254 s) : 0, 1254399
Total [candidate] (11.224 s) : 0, 11223608
section iast
Agent [baseline] (1.24 s) : 0, 1239781
Total [baseline] (11.341 s) : 0, 11341183
Agent [candidate] (1.237 s) : 0, 1237213
Total [candidate] (11.425 s) : 0, 11424772
section profiling
Agent [baseline] (1.19 s) : 0, 1189804
Total [baseline] (11.001 s) : 0, 11001120
Agent [candidate] (1.184 s) : 0, 1184161
Total [candidate] (11.066 s) : 0, 11065706
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (640.403 ms) : 0, 640403
BytebuddyAgent [candidate] (634.472 ms) : 0, 634472
AgentMeter [baseline] (29.87 ms) : 0, 29870
AgentMeter [candidate] (29.434 ms) : 0, 29434
GlobalTracer [baseline] (258.21 ms) : 0, 258210
GlobalTracer [candidate] (258.585 ms) : 0, 258585
AppSec [baseline] (31.829 ms) : 0, 31829
AppSec [candidate] (32.011 ms) : 0, 32011
Debugger [baseline] (60.538 ms) : 0, 60538
Debugger [candidate] (60.916 ms) : 0, 60916
Remote Config [baseline] (634.042 µs) : 0, 634
Remote Config [candidate] (603.292 µs) : 0, 603
Telemetry [baseline] (8.048 ms) : 0, 8048
Telemetry [candidate] (8.134 ms) : 0, 8134
Flare Poller [baseline] (4.295 ms) : 0, 4295
Flare Poller [candidate] (5.078 ms) : 0, 5078
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (660.321 ms) : 0, 660321
BytebuddyAgent [candidate] (663.778 ms) : 0, 663778
AgentMeter [baseline] (12.075 ms) : 0, 12075
AgentMeter [candidate] (12.081 ms) : 0, 12081
GlobalTracer [baseline] (258.186 ms) : 0, 258186
GlobalTracer [candidate] (259.18 ms) : 0, 259180
AppSec [baseline] (177.742 ms) : 0, 177742
AppSec [candidate] (178.003 ms) : 0, 178003
Debugger [baseline] (66.469 ms) : 0, 66469
Debugger [candidate] (65.849 ms) : 0, 65849
Remote Config [baseline] (650.443 µs) : 0, 650
Remote Config [candidate] (649.299 µs) : 0, 649
Telemetry [baseline] (8.262 ms) : 0, 8262
Telemetry [candidate] (8.447 ms) : 0, 8447
Flare Poller [baseline] (3.543 ms) : 0, 3543
Flare Poller [candidate] (4.493 ms) : 0, 4493
IAST [baseline] (24.161 ms) : 0, 24161
IAST [candidate] (24.258 ms) : 0, 24258
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (806.961 ms) : 0, 806961
BytebuddyAgent [candidate] (802.809 ms) : 0, 802809
AgentMeter [baseline] (11.624 ms) : 0, 11624
AgentMeter [candidate] (11.384 ms) : 0, 11384
GlobalTracer [baseline] (248.466 ms) : 0, 248466
GlobalTracer [candidate] (248.93 ms) : 0, 248930
AppSec [baseline] (26.585 ms) : 0, 26585
AppSec [candidate] (26.842 ms) : 0, 26842
Debugger [baseline] (70.268 ms) : 0, 70268
Debugger [candidate] (70.743 ms) : 0, 70743
Remote Config [baseline] (523.822 µs) : 0, 524
Remote Config [candidate] (539.207 µs) : 0, 539
Telemetry [baseline] (9.096 ms) : 0, 9096
Telemetry [candidate] (9.34 ms) : 0, 9340
Flare Poller [baseline] (3.395 ms) : 0, 3395
Flare Poller [candidate] (3.534 ms) : 0, 3534
IAST [baseline] (25.374 ms) : 0, 25374
IAST [candidate] (25.579 ms) : 0, 25579
section profiling
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.171 ms) : 0, 1171
BytebuddyAgent [baseline] (687.3 ms) : 0, 687300
BytebuddyAgent [candidate] (683.509 ms) : 0, 683509
AgentMeter [baseline] (8.99 ms) : 0, 8990
AgentMeter [candidate] (9.017 ms) : 0, 9017
GlobalTracer [baseline] (215.766 ms) : 0, 215766
GlobalTracer [candidate] (215.224 ms) : 0, 215224
AppSec [baseline] (32.37 ms) : 0, 32370
AppSec [candidate] (32.41 ms) : 0, 32410
Debugger [baseline] (66.465 ms) : 0, 66465
Debugger [candidate] (65.341 ms) : 0, 65341
Remote Config [baseline] (571.776 µs) : 0, 572
Remote Config [candidate] (576.335 µs) : 0, 576
Telemetry [baseline] (7.807 ms) : 0, 7807
Telemetry [candidate] (8.529 ms) : 0, 8529
Flare Poller [baseline] (3.525 ms) : 0, 3525
Flare Poller [candidate] (3.514 ms) : 0, 3514
ProfilingAgent [baseline] (94.147 ms) : 0, 94147
ProfilingAgent [candidate] (93.848 ms) : 0, 93848
Profiling [baseline] (94.703 ms) : 0, 94703
Profiling [candidate] (94.406 ms) : 0, 94406
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078592
Total [baseline] (8.917 s) : 0, 8917336
Agent [candidate] (1.071 s) : 0, 1070635
Total [candidate] (8.917 s) : 0, 8917414
section iast
Agent [baseline] (1.233 s) : 0, 1232985
Total [baseline] (9.59 s) : 0, 9590182
Agent [candidate] (1.242 s) : 0, 1242313
Total [candidate] (9.646 s) : 0, 9646396
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (638.728 ms) : 0, 638728
BytebuddyAgent [candidate] (636.938 ms) : 0, 636938
AgentMeter [baseline] (30.521 ms) : 0, 30521
AgentMeter [candidate] (29.688 ms) : 0, 29688
GlobalTracer [baseline] (263.789 ms) : 0, 263789
GlobalTracer [candidate] (259.779 ms) : 0, 259779
AppSec [baseline] (33.012 ms) : 0, 33012
AppSec [candidate] (32.104 ms) : 0, 32104
Debugger [baseline] (61.597 ms) : 0, 61597
Debugger [candidate] (59.954 ms) : 0, 59954
Remote Config [baseline] (617.106 µs) : 0, 617
Remote Config [candidate] (605.759 µs) : 0, 606
Telemetry [baseline] (8.39 ms) : 0, 8390
Telemetry [candidate] (8.163 ms) : 0, 8163
Flare Poller [baseline] (4.427 ms) : 0, 4427
Flare Poller [candidate] (5.885 ms) : 0, 5885
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (800.581 ms) : 0, 800581
BytebuddyAgent [candidate] (805.93 ms) : 0, 805930
AgentMeter [baseline] (11.463 ms) : 0, 11463
AgentMeter [candidate] (11.66 ms) : 0, 11660
GlobalTracer [baseline] (248.98 ms) : 0, 248980
GlobalTracer [candidate] (250.441 ms) : 0, 250441
AppSec [baseline] (26.426 ms) : 0, 26426
AppSec [candidate] (27.135 ms) : 0, 27135
Debugger [baseline] (67.721 ms) : 0, 67721
Debugger [candidate] (66.576 ms) : 0, 66576
Remote Config [baseline] (555.359 µs) : 0, 555
Remote Config [candidate] (533.637 µs) : 0, 534
Telemetry [baseline] (10.681 ms) : 0, 10681
Telemetry [candidate] (12.438 ms) : 0, 12438
Flare Poller [baseline] (3.883 ms) : 0, 3883
Flare Poller [candidate] (4.217 ms) : 0, 4217
IAST [baseline] (25.322 ms) : 0, 25322
IAST [candidate] (25.872 ms) : 0, 25872
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (17.78 ms) : 17603, 17958
. : milestone, 17780,
appsec (18.687 ms) : 18501, 18873
. : milestone, 18687,
code_origins (17.883 ms) : 17707, 18059
. : milestone, 17883,
iast (17.846 ms) : 17668, 18024
. : milestone, 17846,
profiling (18.818 ms) : 18630, 19006
. : milestone, 18818,
tracing (17.931 ms) : 17753, 18108
. : milestone, 17931,
section candidate
no_agent (18.232 ms) : 18044, 18421
. : milestone, 18232,
appsec (19.918 ms) : 19712, 20123
. : milestone, 19918,
code_origins (17.909 ms) : 17732, 18085
. : milestone, 17909,
iast (18.086 ms) : 17906, 18266
. : milestone, 18086,
profiling (19.678 ms) : 19483, 19873
. : milestone, 19678,
tracing (17.57 ms) : 17396, 17744
. : milestone, 17570,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.222 ms) : 1210, 1234
. : milestone, 1222,
iast (3.135 ms) : 3095, 3175
. : milestone, 3135,
iast_FULL (5.989 ms) : 5929, 6050
. : milestone, 5989,
iast_GLOBAL (3.62 ms) : 3565, 3674
. : milestone, 3620,
profiling (2.289 ms) : 2267, 2311
. : milestone, 2289,
tracing (1.891 ms) : 1874, 1908
. : milestone, 1891,
section candidate
no_agent (1.288 ms) : 1274, 1302
. : milestone, 1288,
iast (3.245 ms) : 3205, 3286
. : milestone, 3245,
iast_FULL (6.151 ms) : 6087, 6216
. : milestone, 6151,
iast_GLOBAL (3.532 ms) : 3480, 3584
. : milestone, 3532,
profiling (2.099 ms) : 2080, 2117
. : milestone, 2099,
tracing (1.897 ms) : 1878, 1916
. : milestone, 1897,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (15.563 s) : 15563000, 15563000
. : milestone, 15563000,
appsec (14.575 s) : 14575000, 14575000
. : milestone, 14575000,
iast (18.506 s) : 18506000, 18506000
. : milestone, 18506000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (14.941 s) : 14941000, 14941000
. : milestone, 14941000,
tracing (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
section candidate
no_agent (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
appsec (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
iast (17.976 s) : 17976000, 17976000
. : milestone, 17976000,
iast_GLOBAL (18.059 s) : 18059000, 18059000
. : milestone, 18059000,
profiling (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
tracing (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a62596a62b, baseline=1.61.0-SNAPSHOT~92b8b827eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1500
. : milestone, 1489,
appsec (3.84 ms) : 3618, 4062
. : milestone, 3840,
iast (2.292 ms) : 2223, 2362
. : milestone, 2292,
iast_GLOBAL (2.326 ms) : 2256, 2396
. : milestone, 2326,
profiling (2.139 ms) : 2082, 2195
. : milestone, 2139,
tracing (2.094 ms) : 2040, 2147
. : milestone, 2094,
section candidate
no_agent (1.491 ms) : 1480, 1503
. : milestone, 1491,
appsec (2.55 ms) : 2495, 2605
. : milestone, 2550,
iast (2.284 ms) : 2215, 2353
. : milestone, 2284,
iast_GLOBAL (2.316 ms) : 2247, 2385
. : milestone, 2316,
profiling (2.122 ms) : 2065, 2178
. : milestone, 2122,
tracing (2.08 ms) : 2027, 2133
. : milestone, 2080,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
cd5bbe1
into
master
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Surround system-tests refs in quotes to force string semantics (e.g. in case hex values begin with
0x)Motivation
Address comment in #10966
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-598
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.