Skip to content

plugin new/pin hardening: handle-based pin digest, raw-line JSON, GOWORK in build steps, error reasons and limits, adopted dir mode (#359) #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielNetzer merged 2 commits into from
Nov 4, 2026
Merged

plugin new/pin hardening: handle-based pin digest, raw-line JSON, GOWORK in build steps, error reasons and limits, adopted dir mode (#359) #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
795f5aa
plugin new/pin hardening: handle-based pin digest, raw-line JSON, GOW…
Nov 4, 2026
02df259
test: hold the original temp manifest open in the identical-file swap…
Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lab/internal/cli/plugin_new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ func runPluginNew(args []string, out, stderr io.Writer) int {
fmt.Fprintf(out, " node -p 'require(\"fs\").realpathSync(process.execPath)'\n")
default:
fmt.Fprintf(out, "Wrote the %s plugin skeleton %s.\nNext, build the server, pin the manifest to it and test it:\n", flags["--kind"], name)
fmt.Fprintf(out, " go -C %s build -o %s .\n", shown, name)
// GOWORK=off and an empty GOFLAGS keep a go.work above the directory
// and the user's GOFLAGS from changing what is built.
for _, line := range scaffold.GoBuildCommand(shown, name) {
fmt.Fprintf(out, " %s\n", line)
}
fmt.Fprintf(out, " forgecell plugin pin %s --server %s/%s\n", shown, shown, name)
fmt.Fprintf(out, " forgecell plugin test %s/%s\n", shown, scaffold.ManifestFile)
}
Expand Down
Loading
Loading