Skip to content

Intake: allow new docs-only Markdown files in a directory without a component manifest #364

Closed

Description

@DanielNetzer

readiness/repository.go accepts a new scope path only when a go.mod, package.json or pyproject.toml in the evidence covers its directory. A repository's root docs/ folder usually has no manifest, so a Molecule can edit docs/*.md but never create one.

Example: slice 6d (#357) had to move the design's docs/plugins.md to lab/plugins/README.md because intake refused it with "new path docs/plugins.md needs evidence for its parent component".

Proposal: treat a new Markdown file (*.md) as supported when its parent directory already holds a tracked file in the frozen snapshot. Keep the manifest rule for code, so code files still need a component. Include a test for docs/new.md (accepted when docs/install.md exists) and for docs/new.go (still refused).

Done when

  • go test -timeout 20m ./internal/readiness/... passes from lab/.

Operator decisions (2026-11-04):

  • A new file is accepted without a component manifest only when its name ends in .md (lower case) and its parent directory already holds a tracked file in the frozen snapshot. That includes the repository root, which holds README.md.
  • Paths under a dot-directory (any path segment starting with ., such as .github/ or .claude/) keep the manifest rule, because those directories hold policy and agent configuration.
  • Every other rule is unchanged: traversal, symlinks, scope limits and the manifest rule for every other file.
  • The plan, the ledger and the scope audit name the Markdown rule as the reason a path was accepted.

Tests: docs/new.md is accepted when docs/install.md is tracked. docs/new.go and docs/new.MD are refused. newdir/new.md is refused when no tracked file is in newdir/. .github/new.md is refused. A root NEW.md is accepted. Every existing readiness test is unchanged.

Plan checks for this slice

Use one combined targeted go test -timeout 20m ./internal/readiness/... check. Every plan check leaves reviewedAcceptance and independentProvenance empty.


Review checklist (read before coding)

The adversarial review checks these every time. Recent slices failed review on all of them, so build them in from the start:

  • Bounds: sizes, counts, time and total work are bounded, and hitting a bound fails safe (incomplete or truncated, never silently accepted).
  • Filesystem safety: paths cannot traverse. Use Lstat and O_NOFOLLOW, and check symlinks and ownership. Watch for TOCTOU races on shared dirs (/tmp). Only ever delete Forgecell-owned, marked paths.
  • Untrusted input: issue text, repository files, model and tool output, and ledgers can be malformed, huge or hostile. Validate them, never interpolate them into HTML or a shell, and never let them trigger retries or approvals.
  • No local leaks: no absolute local paths, environment variables or credentials in output, logs, the UI or ledgers.
  • Contract changes: a changed adapter invocation bumps the protocol, and approved digests still bind exactly what was shown.
  • Tests: deterministic. Use no wall-clock budgets (use readiness markers or seams), write nothing into the user's real temp or home, and cover the failure path as well as the happy path.

Plan checks (for intake)

Check category must be one of regression, candidate or setup. Use targeted package tests only as plain go test -timeout 20m commands (for example go test -timeout 20m ./internal/<pkg>/...; without -timeout, go test stops a package after 10 minutes, and cli and molecule exceed that on a loaded machine); the protected view adds -json itself when protected deltas are declared. The Formula baseline already runs the full suite once, so don't add another full go test ./... check, and don't repeat its go vet or gofmt checks. A plan may hold at most 16 checks in total, counting the 5 Formula baseline checks, so prefer one combined targeted command over one check per package.

  • Keep base tests compiling: the protected view runs the base _test.go files against your code. Never change the signature of an existing function, method or type that a base test file calls. Add a new function or field instead. A protected build failure can't be declared as an expected delta.
  • Keep base tests runnable: changed defaults or behaviour must not make a base test hang or panic. A package that aborts in the protected view hides every test after it, and nothing can be declared. Keep the old default when unconfigured and opt in to the new one.
  • Plan checks: the operator's visual or browser check is a manual step after delivery, never a plan check. Every check leaves reviewedAcceptance and independentProvenance empty.
  • Plan structure: new files need a parent component (in this repo, under lab/; a new root-level file blocks intake). A check's definitions must never include a file the change edits. A file the check only reads as data under test is not a definition.
  • Scope lists files, not directories: list every new file path, including each golden fixture under testdata/. A directory entry doesn't cover the files inside it, and the scope audit blocks them.

Activity

  1. DanielNetzer commented on Nov 4, 2026

    @DanielNetzer
    OwnerAuthor

    Fixed in #373: a new lower-case .md file is accepted without a component manifest when its directory already holds a tracked file. Dot-directories keep the manifest rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    post-v1Not needed for v1; parked until v1 ships

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions