Skip to content

forgecomments markers: code spans, reference links, negation forms, Unicode boundaries, indented code (follow-up to #341) #358

Closed

Description

@DanielNetzer

Hardening items from the adversarial review of #341. None of them is a contract violation; each lets a comment's own text raise its severity in a way the #341 rules don't yet cover.

  1. Inline code spans: `High Severity`, ``High Severity`` and `severity: high` are read as markers. Text inside a backtick code span should never count.
  2. Reference-style links: [high][ref], [high][] and [high]: http://x count as tags; only [x]( is refused today.
  3. Negation forms: isn't severity: high, not: severity: high and not, severity: high still yield high. Treat n't and a not/no separated from the marker only by punctuation as negation.
  4. Unicode word boundaries: Go's \b is ASCII-only, so severity: highé matches high. Require a non-letter (Unicode) after the severity word.
  5. Indented code blocks: a line indented four or more spaces outside a list is a CommonMark indented code block and should not be read; an indented ``` is not a fence opener.

Scope: lab/plugins/forgecomments/severity.go, lab/plugins/forgecomments/README.md, new lab/plugins/forgecomments/severity_hardening_test.go.

Done when

  • go test -timeout 20m ./plugins/forgecomments/... passes from lab/.

Plan checks for this slice

Use one combined targeted go test -timeout 20m ./plugins/forgecomments/... check. Keep every existing _test.go unchanged; if a base test asserts behaviour this slice replaces by design, name it in the plan so it can be declared as a protected delta. Every plan check leaves reviewedAcceptance and independentProvenance empty.


Review checklist (read before coding)

The adversarial review checks these every time. Recent slices failed review on all of them, so build them in from the start:

  • Bounds: sizes, counts, time and total work are bounded, and hitting a bound fails safe (incomplete or truncated, never silently accepted).
  • Filesystem safety: paths cannot traverse. Use Lstat and O_NOFOLLOW, and check symlinks and ownership. Watch for TOCTOU races on shared dirs (/tmp). Only ever delete Forgecell-owned, marked paths.
  • Untrusted input: issue text, repository files, model and tool output, and ledgers can be malformed, huge or hostile. Validate them, never interpolate them into HTML or a shell, and never let them trigger retries or approvals.
  • No local leaks: no absolute local paths, environment variables or credentials in output, logs, the UI or ledgers.
  • Contract changes: a changed adapter invocation bumps the protocol, and approved digests still bind exactly what was shown.
  • Tests: deterministic. Use no wall-clock budgets (use readiness markers or seams), write nothing into the user's real temp or home, and cover the failure path as well as the happy path.

Plan checks (for intake)

Check category must be one of regression, candidate or setup. Use targeted package tests only as plain go test -timeout 20m commands (for example go test -timeout 20m ./internal/<pkg>/...; without -timeout, go test stops a package after 10 minutes, and cli and molecule exceed that on a loaded machine); the protected view adds -json itself when protected deltas are declared. The Formula baseline already runs the full suite once, so don't add another full go test ./... check, and don't repeat its go vet or gofmt checks. A plan may hold at most 16 checks in total, counting the 5 Formula baseline checks, so prefer one combined targeted command over one check per package.

  • Keep base tests compiling: the protected view runs the base _test.go files against your code. Never change the signature of an existing function, method or type that a base test file calls. Add a new function or field instead. A protected build failure can't be declared as an expected delta.
  • Keep base tests runnable: changed defaults or behaviour must not make a base test hang or panic. A package that aborts in the protected view hides every test after it, and nothing can be declared. Keep the old default when unconfigured and opt in to the new one.
  • Plan checks: the operator's visual or browser check is a manual step after delivery, never a plan check. Every check leaves reviewedAcceptance and independentProvenance empty.
  • Plan structure: new files need a parent component (in this repo, under lab/; a new root-level file blocks intake). A check's definitions must never include a file the change edits. A file the check only reads as data under test is not a definition.
  • Scope lists files, not directories: list every new file path, including each golden fixture under testdata/. A directory entry doesn't cover the files inside it, and the scope audit blocks them.

Activity

  1. DanielNetzer commented on Nov 4, 2026

    @DanielNetzer
    OwnerAuthor

    Fixed in #372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions