fix: 병합을 squash 기본값으로 바꾸고 auto-merge 대신 즉시 병합#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안타깝게도 리트코드 스터디에서 최근 일부 멤버들이 커밋 히스토리를 어지럽히는 low-qaulity의 PR이 올리고 있습니다. 그래서 main 브랜치의 커밋 히스토리를 지키기 위해서 기본 방합 방식을
squash로 바꿉니다. 여기에 더해 approve/merge 두 job의 Summary 스텝이 실패를 전혀 전파하지 않는 문제도 함께 고칩니다. 그리고PUT /pulls/{n}/merge직접 호출로 교체하면서 auto-merge 활성화를 병합 성공으로 보고하던 문제도 해결했고, 더 이상 쓰이지 않는getPullRequestNodeId()는 정리했습니다.