fix: #165 disable completion in comments - #227
Open
liuxy0551 wants to merge 2 commits into
Open
Conversation
Collaborator
Cythia828
reviewed
Aug 12, 2026
Collaborator
Author
|
这里确实是依赖各方言 Monaco tokenizer 的注释识别结果来决定是否关闭补全。 当前实现的目标是:一旦光标已经处于该方言 tokenizer 识别出的注释区域内,就在 Monaco 层直接短路,不再触发 worker、C3 和 completionService。 因此像 MySQL 这类方言,如果其现有 tokenizer 会把某些输入识别为注释,这次补全逻辑会沿用同一套方言语义,不会再单独引入另一套注释判定规则。本次 PR 只收敛在共享 CompletionAdapter,不调整各方言 tokenizer 或 dt-sql-parser 的注释定义。 |
Cythia828
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



改动内容
#165
*/之后的位置#注释、块注释及非注释边界场景单测预览地址
https://liuxy0551.github.io/monaco-sql-languages/