fix: escape metadata values in DirectoryMetadata.__createMetaSelection#8708
Merged
chrisburr merged 1 commit intoJul 13, 2026
Merged
Conversation
__createMetaSelection interpolated user-supplied metadata operands
directly into the SQL selection string (e.g. "{table}Value='{operand}'"),
and the callers (__findSubdirByMeta, __checkDirsForMetadata) execute the
resulting query with no bound args, so a crafted metadata query value was
live SQL -> injection via findDirectoriesByMetadata.
Escape every string operand through the DB _escapeString/_escapeValues
helpers (which quote and escape the value) before inlining it, mirroring
the FileMetadata.__createMetaSelection sibling which already does this.
Numeric operands keep their existing safe %d/%f handling.
This defect predates the SQL-parameterisation series.
sfayer
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*DataManagementSystem
FIX: escape user-supplied metadata values in DirectoryMetadata
ENDRELEASENOTES