Skip to content

Fix android bug where dynamic content In StepFlowItem gets cut - #914

Merged
eirinsvi merged 3 commits into
mainfrom
eisv/issue-1931
Jul 22, 2026
Merged

Fix android bug where dynamic content In StepFlowItem gets cut#914
eirinsvi merged 3 commits into
mainfrom
eisv/issue-1931

Conversation

@eirinsvi

Copy link
Copy Markdown
Contributor

Description of Change

Fixes https://dips.ghe.com/dips/Arena.Mobile/issues/1931

Todos

  • I have tested on an Android device.
  • I have tested on an iOS device.
  • I have supported accessibility

Buggen er bare klart reprodusert på Samsung SM (kan testes på componentSamples)

Copilot AI review requested due to automatic review settings July 20, 2026 08:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an Android-specific layout/animation issue in StepFlowItem where dynamically added body content could be clipped during the activation/expand animation. It does so by making the expand animation adapt its target height while the body is expanding, and updates the StepFlow sample to reproduce the scenario with dynamically populated content.

Changes:

  • Updated StepFlowItem expand animation to animate normalized progress (0→1) and adjust the target height during expansion when content grows.
  • Updated StepFlow sample to dynamically populate the final step’s content on StepActivated to reproduce the clipping scenario.
  • Added a patch changelog entry for the Android StepFlow fix.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

📁 File summary (4 files changed)
File Description
src/library/DIPS.Mobile.UI/Components/StepFlow/StepFlowItem.cs Adjusts expand animation to re-measure/re-target height during expansion so dynamic content isn’t clipped.
src/app/Components/ComponentsSamples/StepFlow/StepFlowSamplesViewModel.cs Adds dynamic population of step 4 content on activation to reproduce the issue in samples.
src/app/Components/ComponentsSamples/StepFlow/StepFlowSamples.xaml Updates the sample UI to include an intermediate step and a dynamically populated final step.
CHANGELOG.md Adds a [62.0.2] patch entry documenting the Android StepFlow fix.

Comment thread src/library/DIPS.Mobile.UI/Components/StepFlow/StepFlowItem.cs Outdated
Comment thread src/app/Components/ComponentsSamples/StepFlow/StepFlowSamples.xaml Outdated
eirinsvi and others added 2 commits July 20, 2026 10:39
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@eirinsvi
eirinsvi merged commit db47d28 into main Jul 22, 2026
1 check passed
@eirinsvi
eirinsvi deleted the eisv/issue-1931 branch July 22, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants