Skip to content

Add battery_capacity_kwh field - #311

Closed
zer0stars wants to merge 1 commit into
mainfrom
add-battery-capacity-kwh
Closed

Add battery_capacity_kwh field#311
zer0stars wants to merge 1 commit into
mainfrom
add-battery-capacity-kwh

Conversation

@zer0stars

@zer0stars zer0stars commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds battery_capacity_kwh as a first-class field, mirroring the existing fuel_tank_capacity_gal pattern
  • Added to DrivlyVINResponse (float64), Vincario GetMetadata() map, and VehicleInfo struct

Test plan

  • Verify go build ./... passes
  • Verify go test -race ./... passes
  • Confirm Drivly VIN decode populates batteryCapacityKwh for a known EV VIN

@zer0stars
add battery_capacity_kwh field to match fuel_tank_capacity_gal
c8f4921 
Add BatteryCapacityKwh to DrivlyVINResponse, Vincario metadata map,
and VehicleInfo struct so EV battery capacity is a first-class field.
zer0stars added a commit that referenced this pull request Sep 14, 2026
@zer0stars
Merge #311 (battery_capacity_kwh field) into r2-device-definitions
ede41b8
zer0stars added a commit that referenced this pull request Sep 14, 2026
@zer0stars
chore: gofmt the #311 field and pin the #312 low-confidence sources
3d619e6 
The battery_capacity_kwh field #311 added to VehicleInfo was not gofmt
aligned. The set of decode sources #312 refuses to create templates from
now has a unit test, so adding or dropping a provider there is a visible
change.
@zer0stars

zer0stars commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Folded into #314 so device-definitions-api has one open PR for this work. The commit is preserved there through merge commit ede41b8.

@zer0stars zer0stars mentioned this pull request Sep 14, 2026
Open
@zer0stars zer0stars closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JamesReate JamesReate JamesReate approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zer0stars @JamesReate