add some additional item types - #912
Merged
Merged
Conversation
reflects actual seen usage as of 53.16
quietust
reviewed
Sep 24, 2026
| @@ -1822,6 +1822,7 @@ | |||
| </enum-item> | |||
| <enum-item name='ANY_GOOD_FOOD' original-name='good'> | |||
Member
There was a problem hiding this comment.
Just noticed: original-name should be food, not good
quietust
reviewed
Sep 24, 2026
|
|
||
| <enum-item name='ANY_GLASSABLE' original-name='i_glassable'> | ||
| <item-attr name='generic_item' value='BOX'/> | ||
| <item-attr name='generic_item' value='BAG'/> |
Member
There was a problem hiding this comment.
This should actually replace BOX
Edit: there are several other places that need similar treatment; I'm going to do a full audit and submit a PR against this branch with my findings.
Edit 2: see #913
ANY_GOOD_FOOD: remove BOX ANY_EDIBLE_VERMIN_BOX: remove BOX, add FISH_RAW ANY_EDIBLE_VERMIN: add most of ANY_EDIBLE_VERMIN_BOX (everything but BARREL+BAG) ANY_CAN_ROT: remove SEEDS ANY_COOKABLE: remove BOX ANY_GLASSABLE: remove BOX
audit all item array usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reflects actual seen usage as of 53.16