Skip to content

[3089] Remove Cache for Redis - #37

Merged
jonbamber merged 2 commits into
mainfrom
3089-remove-redis
Nov 11, 2026
Merged

jonbamber merged 2 commits into
mainfrom
3089-remove-redis

Conversation

@jonbamber

@jonbamber jonbamber commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Context

This change is to remove the Redis resources as they are not used.

https://trello.com/c/GmwGMitl/3089-service-drd-migrate-redis

Changes proposed in this pull request

This change completely removes Redis configuration (the redis-cache module block in terraform/application/database.tf) - the effect of this will be to destroy the Cache for Redis resources.

The application does not reference Redis: there are no Redis environment variables, secrets or configuration in the application, and no Redis gem in the Gemfile. When checked, command statistics from the Redis cache showed only platform and polling commands, with no application commands.

Guidance to review

Run the following command to generate a Terraform plan and ensure planned changes are as expected:

  • make test terraform-plan DOCKER_IMAGE_TAG=e16bef8b0761fdb9bed00c445745b781b5f02132 will show Plan: 0 to add, 0 to change, 2 to destroy with the removal of Redis resources:
    • module.redis-cache.azurerm_redis_cache.main[0]
    • module.redis-cache.azurerm_private_endpoint.main[0]

Checklist

  • Tested by running locally
  • Performed self-review
  • Rebased onto main
  • Cleaned commit history
  • Attached to Trello card

@jonbamber jonbamber self-assigned this Nov 10, 2026
@jonbamber
jonbamber requested review from rgwenter-mobi and a balanced review from Copilot November 10, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

This change destroys live infrastructure, and unavailable Terraform state and plans require human verification that each environment’s plan removes only the unused Redis cache and private endpoint before applying.

No open issues 🎉

What changed in this PR

Removes the unused Redis Terraform module so the cache infrastructure can be decommissioned without changing the PostgreSQL configuration.

Changes:

  • Deletes the redis-cache module and its configuration.
  • Intended to destroy the Azure Redis cache and its private endpoint on the next Terraform apply.
File Description
terraform/​application/​database.tf Removes the Redis module while leaving PostgreSQL unchanged.

Review effort: Balanced

@jonbamber
jonbamber marked this pull request as draft November 10, 2026 15:38
@jonbamber
jonbamber marked this pull request as ready for review November 11, 2026 15:38
Copilot AI balanced review requested due to automatic review settings November 11, 2026 15:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change destroys deployed infrastructure, and the Terraform plan could not be independently validated to confirm that only the unused Redis cache and private endpoint are removed.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 11, 2026 15:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The environment-specific Terraform plan needs independent verification that destruction is limited to the intended Redis cache and private endpoint, as live state and Redis usage telemetry were unavailable.

No open issues 🎉

Review effort: Balanced

@jsomerset jsomerset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redis resources removed in plan and no other changes

@jonbamber
jonbamber merged commit 600761f into main Nov 11, 2026
10 checks passed
@jonbamber
jonbamber deleted the 3089-remove-redis branch November 11, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants