Repository navigation
[3089] Remove Cache for Redis - #37
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
This change destroys live infrastructure, and unavailable Terraform state and plans require human verification that each environment’s plan removes only the unused Redis cache and private endpoint before applying.
No open issues 🎉
What changed in this PR
Removes the unused Redis Terraform module so the cache infrastructure can be decommissioned without changing the PostgreSQL configuration.
Changes:
- Deletes the
redis-cachemodule and its configuration. - Intended to destroy the Azure Redis cache and its private endpoint on the next Terraform apply.
| File | Description |
|---|---|
terraform/application/database.tf |
Removes the Redis module while leaving PostgreSQL unchanged. |
Review effort: Balanced
69e4976 to
39b5409
Compare
39b5409 to
fb7bf5e
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The environment-specific Terraform plan needs independent verification that destruction is limited to the intended Redis cache and private endpoint, as live state and Redis usage telemetry were unavailable.
No open issues 🎉
Review effort: Balanced
jsomerset
left a comment
There was a problem hiding this comment.
Redis resources removed in plan and no other changes
Context
This change is to remove the Redis resources as they are not used.
https://trello.com/c/GmwGMitl/3089-service-drd-migrate-redis
Changes proposed in this pull request
This change completely removes Redis configuration (the
redis-cachemodule block interraform/application/database.tf) - the effect of this will be to destroy the Cache for Redis resources.The application does not reference Redis: there are no Redis environment variables, secrets or configuration in the application, and no Redis gem in the
Gemfile. When checked, command statistics from the Redis cache showed only platform and polling commands, with no application commands.Guidance to review
Run the following command to generate a Terraform plan and ensure planned changes are as expected:
make test terraform-plan DOCKER_IMAGE_TAG=e16bef8b0761fdb9bed00c445745b781b5f02132will showPlan: 0 to add, 0 to change, 2 to destroywith the removal of Redis resources:module.redis-cache.azurerm_redis_cache.main[0]module.redis-cache.azurerm_private_endpoint.main[0]Checklist