Skip to content

Added write permissions to workflow - #36

Merged
jonbamber merged 1 commit into
mainfrom
2968-build-no-cache-permissions
Nov 11, 2026
Merged

jonbamber merged 1 commit into
mainfrom
2968-build-no-cache-permissions

Conversation

@jsomerset

Copy link
Copy Markdown
Contributor

Context

This PR is to resolve a permissions issue preventing the build-no-cache workflow from completing successfully

Changes proposed in this pull request

Add write packages permissions to the build-no-cache job

Guidance to review

Check the following workflow run to confirm it is successful:
https://github.com/DFE-Digital/dfe-reference-data-webapp/actions/runs/32345330695

@jonbamber
jonbamber requested review from jonbamber and a balanced review from Copilot November 10, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Workflow run 32345330695 could not be verified, leaving successful publication of the image and build cache to GHCR pending maintainer confirmation.

No open issues 🎉

What changed in this PR

This PR addresses the package-permission issue blocking the no-cache build workflow.

Changes:

  • Grants packages: write permission to the build-no-cache job so it can publish container images to GitHub Container Registry.

The linked workflow run’s success was not independently verified.

File Description
.github/​workflows/​build-nocache.yml Adds job-level package write permission to the no-cache build.

Review effort: Balanced

@jonbamber
jonbamber force-pushed the 2968-build-no-cache-permissions branch from b1528ea to edfdbdc Compare November 10, 2026 19:03
@jonbamber
jonbamber force-pushed the 2968-build-no-cache-permissions branch from edfdbdc to 17a072d Compare November 11, 2026 15:41
Copilot AI balanced review requested due to automatic review settings November 11, 2026 15:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Workflow run 32345330695 was inaccessible, so a human must confirm that build-no-cache succeeds and publishes the image to GHCR.

No open issues 🎉

Review effort: Balanced

@jonbamber
jonbamber merged commit e16bef8 into main Nov 11, 2026
10 checks passed
@jonbamber
jonbamber deleted the 2968-build-no-cache-permissions branch November 11, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants