Repository navigation
Release v1.0.1 — brand-aware card number and CVV length limits - #26
Merged
Merged
Conversation
The card form accepted up to 19 digits for every brand. The card number is now capped at 15 digits when American Express is detected and at 16 for every other brand. A security code typed for a previous brand is also cut to the new brand length (4 digits for American Express, 3 otherwise) when the card number changes. Co-Authored-By: Claude <noreply@anthropic.com>
Aligns VERSION_NAME, OpenpaySdk.VERSION and the dependency snippets in the README and the four-language getting started guides, so the v1.0.1 tag passes the CD version guard. Co-Authored-By: Claude <noreply@anthropic.com>
…ngths fix: cap card number and CVV lengths by detected brand (v1.0.1)
Unit test coverage
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.0.1
Patch release of
mx.dev1.openpay:openpay-sdkthat fixes two input bugs in the card form. It contains everything merged intodevelopthrough #25.What's fixed
Card number length
Security code (CVV) length
API changes
CardBrand.cardNumberLength(15 forAMERICAN_EXPRESS, 16 forVISA,MASTERCARDandUNKNOWN).OpenpayCardFormState.updateCardNumbercaps the input by the detected brand and trims the security code to the brand length.CardBrand's constructor gained a parameter, but enum constructors are not callable by host apps, so no host code needs to change.Not changed
CardValidator.isValidCardNumberstill accepts 12–19 digit numbers that pass Luhn. Only the form input is capped.CardNumberVisualTransformationkeeps its grouping for hosts that use it outside the form state.Version and docs
VERSION_NAME(gradle.properties) andOpenpaySdk.VERSION→1.0.1.README.mdand the EN/ES/FR/PT getting started guides →1.0.1.docs/*/ui-components.md(EN/ES/FR/PT) describe the card number cap.Included pull requests
After merging
CD runs on a
v*tag and checks that the tag equalsVERSION_NAME:v1.0.1on themastermerge commit → CD runs the tests and coverage gate, uploads the signed artifacts, promotes the staging repository to the Central Portal and creates the GitHub release.Test plan
./gradlew testDebugUnitTest jacocoTestReport :openpay-sdk:jacocoCoverageVerificationpassed locally on the fix: cap card number and CVV lengths by detected brand (v1.0.1) #25 branch🤖 Generated with Claude Code