fix(helm): configure data service cache port - #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds
CACHE_DB_PORTto the Data Service secret, matching the existing Consumer Service and Metadata Service configuration.Why
Without an explicit value, Kubernetes service-link injection can populate
CACHE_DB_PORTwith a URL such astcp://<cluster-ip>:6379. Spring expects this setting to be an integer, causing the Data Service to fail during startup with aNumberFormatException.Impact
Helm deployments now provide the configured cache port to the Data Service and no longer depend on Kubernetes generated service-link variable.
Validation
git diff --checkpasses.helm/dbrepo/templates/data-secret.yaml.gatewayservice.containerPorts.http).