Repository navigation
Fix table diagnostic JSON reading from database header - #122
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For a valid database produced by
DatabaseBuilder.Build(),MemoryDatabase.GetTableInfo(binary)[0].DumpAsJson()reads the database header instead of the table records. With the existing Sample fixture plus ItemMaster, the first table dump is{"s_a_m_p_l_e":[0,193],"item_master":[193,10]}rather than the Sample array.The header stores table offsets relative to the payload after the header.
GetTableInfopasses those offsets toTableInfoagainst the complete binary, so the copied bytes start too early. Normal database loading already slices past the header.Change
Add the consumed header length when constructing diagnostic table info. No binary format or public API changes. Add a regression exercising first and subsequent tables and both
DumpAsJsonoverloads with the maintained synthetic fixtures.Validation
dotnet build -c Release: passed.dotnet test -c Release --no-build: 29 runtime and 7 generator tests passed.dotnet pack -c Release --no-build -p:IncludeSymbols=true -p:SymbolPackageFormat=snupkg: passed.