Skip to content

fix: resolve C3 export pipeline login and listener issues - #74

Open
Armaldio wants to merge 106 commits into
mainfrom
develop
Open

fix: resolve C3 export pipeline login and listener issues#74
Armaldio wants to merge 106 commits into
mainfrom
develop

Conversation

@Armaldio

@Armaldio Armaldio commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the Construct 3 export pipeline's "stuck on login" bug and improves dialog listener reliability.

Changes

Login credential injection fix

  • Root cause: Credentials were injected into 's IndexedDB, but the editor at reads from its own origin's IndexedDB
  • Fix: Navigate to first, then inject credentials using the editor's own instance, followed by a page reload

Browser download optimization

  • Respect existing env var (was hardcoded)
  • Skip if chrome binary already exists at the expected path

Dialog listener improvements

  • Register all 8 dialog listeners immediately after navigation/login (was split across two phases)
  • Add recursive re-registration to listener (was missing, unlike all other listeners)

E2E test

  • New test: reads / from environment, skips if not set

Testing

All 3 E2E tests pass:

  • ✅ Anonymous export
  • ✅ Logged-in export (with env vars)
  • ✅ Custom Chrome profile clone

Files changed

  • plugins/plugin-construct/src/assets/script.ts — login injection + listener registration
  • plugins/plugin-construct/src/assets/listeners.ts — notNowBtn recursive re-registration
  • plugins/plugin-construct/src/export-shared.ts — browser path + download skip
  • plugins/plugin-construct/tests/e2e/construct.spec.ts — login E2E test

Armaldio and others added 30 commits May 4, 2026 14:29
@Armaldio
moved to monorepo
e1befbf
@github-actions
Version Packages (beta) (#68)
c512609 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Armaldio
fix: remove redundant --tag from changeset publish
7ed0256
@Armaldio
Merge branch 'develop' of github.com:CynToolkit/pipelab into develop
e48ddf7
@Armaldio
ci: bypass change detection on main and develop branches and update p…
72bda6d 
…ublication condition
@Armaldio
feat: add --ignore flag to filter tags and releases via patterns or s…
d0d61b6 
…emver ranges and update deletion logic to clean up associated tags
@Armaldio
feat: implement dynamic desktop release fetching from GitHub API for …
7f3b334 
…auto-updater with support for environment-based overrides
@Armaldio
-
f50b8a0
@Armaldio
refactor: simplify window loading logic and ensure consistent ready-t…
1e7d7a9 
…o-show handling across environments
@Armaldio
feat: implement asynchronous background plugin loading with UI progre…
42cf317 
…ss tracking
@Armaldio
chore: integrate oxfmt for project-wide code formatting and update fo…
317c1e2 
…rmatting scripts
@Armaldio
feat: add script to interactively select and unpublish npm package ve…
3c70800 
…rsions
@Armaldio
refactor: simplify migration system, remove down functions, and add e…
b3c60d2 
…nvironment-aware user data paths
@Armaldio
feat: implement dynamic release tagging and bundle identification to …
3bdf365 
…support beta channel distribution
@Armaldio
Fix bump
c57d828
@Armaldio
chore: bump versions for packages and plugins and update release work…
89006a7 
…flow configuration
@Armaldio
fix(ci): restore pipeline.yml from commit 317c1e2
9ead885
@Armaldio
Fix bump
4b96993
@Armaldio
chore: remove changeset pre-mode workflow steps
bf8eac4
@Armaldio
chore: bump versions for all packages and plugins
efbac2a
@Armaldio
fix: ensure atomic package installation and verify dependency presenc…
2faa6e8 
…e in core-node, and bump versions to 1.0.0-beta.8/2.0.0-beta.8
@Armaldio
fix: remove hyphen from beta product name to ensure consistency
cf7004e
@Armaldio
chore: bump versions for beta release and fix constants directory path
ec76a22
@Armaldio
chore: bump versions, update plugin configurations, and improve deskt…
0520418 
…op server-process path resolution
@Armaldio
feat: enable shims in tsdown configuration for all plugins and update…
03d267b 
… versions to 1.0.0-beta.11
@Armaldio
feat: implement cross-platform update notifications with manual downl…
c1d76be 
…oad support for unsupported OS
@Armaldio
refactor: apply consistent code formatting and add performance instru…
fba726f 
…mentation to plugin loading
@Armaldio
feat: skip npm publish if version is already registered
8bd1fa4
@Armaldio
bump
6472e26
@Armaldio
-
5ce5ba5
Armaldio added 30 commits July 2, 2026 18:42
@Armaldio
refactor: standardize development environment detection and improve m…
b446de4 
…edia URL path decoding and handling
@Armaldio
refactor: improve plugin version display in UI, enhance error logging…
4f14bee 
…, and add safety checks to build output handling
@Armaldio
refactor: isolate Poki upload process by using temporary directories …
135069b 
…and improve type safety for PipelabContext paths.
@Armaldio
-
f6492ee
@Armaldio
-
4382e43
@Armaldio
-
b68c9ab
@Armaldio
-
4eb3f9d
@Armaldio
-
519b12a
@Armaldio
-
591f06b
@Armaldio
-
f79c1ab
@Armaldio
-
80cf2c8
@Armaldio
-
66f065a
@Armaldio
-
b346a0f
@Armaldio
feat: inject pnpm binary shims into build PATH for improved execution…
7f49f65 
… support
@Armaldio
fix: conditionally generate pnpm shim based on OS platform and bump v…
e82c2ad 
…ersion to 1.0.0-beta.34
@Armaldio
chore: bump versions for all packages and resolve pnpm path in test-u…
f251898 
…tils sandbox
@Armaldio
feat: force hoisted node-linker in generated .npmrc to resolve electr…
fa51a87 
…on-forge errors
@Armaldio
chore: bump @pipelab/plugin-electron version to 1.0.0-beta.36
64586d6
@Armaldio
refactor: downgrade internal logs to debug and remove obsolete npm an…
06d5600 
…d simulation files
@Armaldio
chore: bump project versions and update changelogs
cb35d0b
@Armaldio
feat: implement plugin initialization wait mechanism to ensure runner…
1f2c53b 
… readiness before UI launch
@Armaldio
fix: improve SteamCMD authentication handling by disabling interactiv…
3436793 
…e prompts and disabling shell execution
@Armaldio
refactor: centralize plugin definitions and improve dynamic plugin di…
53bae0a 
…scovery validation
@Armaldio
chore: bump versions and update changelogs for all Pipelab packages a…
29a123f 
…nd plugins
@Armaldio
fix: handle headless mode for electron file operations, alerts, and p…
eb3dc4e 
…rompts
@Armaldio
fix: resolve electron file copy issue in @pipelab/plugin-electron
31fcefe
@Armaldio
feat: implement artifacts collection support and refactor build histo…
ba82dcd 
…ry UI components.
@Armaldio
feat: improve dark theme and build history across various packages an…
99496c0 
…d plugins
@Armaldio
feat: add setArtifact method to test runner mock interface
98dccf9
@Armaldio
fix: resolve C3 export pipeline login and listener issues
639c221 
- Fix login credential injection: inject on editor.construct.net origin
  using localforage instead of raw IndexedDB on account.construct.net
- Respect existing PLAYWRIGHT_BROWSERS_PATH env var
- Skip browser download if chrome binary already exists
- Register all dialog listeners immediately after navigation/login
- Add recursive re-registration to notNowBtn listener
- Add E2E test for login with env vars (C3_USERNAME/C3_PASSWORD)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Armaldio