fix: refresh library views after stats update - #540
Open
itsmeares wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh Jellystat's materialized views after library statistics are recalculated.
Problem
After a Jellyfin sync,
jf_librariescan contain the correct library counts while the Libraries page continues to display stale values fromjs_library_stats_overview.I reproduced this while validating Jellystat against Jellyfin 12.
After a completed full sync, the database contained:
However, the Libraries page still displayed:
Manually running:
immediately updated the UI to the correct 51 / 34 / 100 / 1019 counts.
Root cause
updateLibraryStatsData()callsju_update_library_stats_data()to write the final library counters, but the materialized views are not refreshed afterwards.The existing
db.query()helper already supports refreshing all entries indb.materializedViews.Change
Reuse the existing refresh mechanism:
Because both full and partial sync call
updateLibraryStatsData(), both paths receive the corrected behavior.Validation
Validated against Jellystat 1.1.11 connected to Jellyfin 12.0.0 RC5.
Before materialized view refresh:
After refresh:
No schema changes, migrations, new dependencies, or additional helpers are required.