Repository navigation
Add exact window modes to App - #331
Open
zengfanfan wants to merge 5 commits into
Open
zengfanfan wants to merge 5 commits into
zengfanfan wants to merge 5 commits into
Conversation
zengfanfan
marked this pull request as ready for review
July 13, 2026 12:06
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
zengfanfan
force-pushed
the
feature/exact-window-control
branch
from
July 18, 2026 13:21
866f2aa to
7358578
Compare
gustavocassanosm-bot
approved these changes
Sep 16, 2026
zengfanfan
force-pushed
the
feature/exact-window-control
branch
from
October 2, 2026 17:00
7358578 to
d090126
Compare
zengfanfan
force-pushed
the
feature/exact-window-control
branch
from
October 3, 2026 09:44
d090126 to
5587e8d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add deterministic native window operations as explicit modes of the existing
Apptool:find_windowfilters by HWND, process ID, process basename, and exact or partial title, and returns native identity and outer/client geometry.activate_windowrequires an HWND, supports optional identity assertions, and verifies the foreground HWND after activation.set_window_boundsrequires an HWND and exactly one outer or client rectangle, and reads back the resulting geometry.launch,launch_executable,resize, andswitchmodes keep their current contracts. Exact-mode parameters cannot silently fall through to a legacy mode.The implementation uses an internal
ExactWindowController; it does not register a new public MCP tool. On the currentmain(which includes #445), exact activation and resizing check control ownership before each Win32 state-changing step. If the user takes over, remaining steps stop; legacyAppmodes retain their existing behavior.Motivation
The existing name-based modes are useful for convenient interactive automation, but fuzzy selection is unsuitable when a caller already has a native window identity. Explicit modes keep exact operations in the existing application/window tool.
Testing
ruff checkandruff format --checkpassed on all six changed Python files.tests/test_analytics.py(cannot create a directory inside this environment's read-only worktree) andtests/test_cli_legacy_flags.py(requires Windows scheduled-task registration privileges). This is not an unfiltered full-suite result.pyproject.tomlrequires Python >=3.14. The GitHub CI run for this PR head passed on Python 3.14: 929 passed, 7 warnings.Screenshots
Not applicable; no UI is added.
Related Issues
None.