Add locale-aware renderer-independent NumberInput - #242
Open
woksin wants to merge 1 commit into
Open
Conversation
Build Fix RequiredThe "JavaScript Build" workflow is failing on this PR due to an outdated yarn lockfile entry. See issue #243 for details. Quick fix: Remove the obsolete The entry spans 7 lines and is located before the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Cratis-owned numeric input for applications that need locale formatting without exposing renderer implementation types. The standalone control and CommandForm adapter share one parsing, formatting, validation, accessibility, parts, and token contract.
Added
NumberInputand sharedNumberInputFieldCommandForm adapter. (Add a locale-aware renderer-independent number input #175)Fixed
onChangebeforeonCommit. (Add a locale-aware renderer-independent number input #175)Public contract
NumberInputis controlled throughnumber | null, takes its BCP 47 locale fromCratisComponentsProviderwith an optional per-control override, and supports grouping, fraction policy, bounds, stepping, prefixes, suffixes, native form semantics, descriptions, errors, and disabled/read-only/invalid states.onChange;onCommitreportsblur,enter,paste, orstepafter any corresponding change. Controlled normalization is withheld from form submission until the owner accepts it.--cratis-number-input-*token aliases provide the styling contract. No React Aria or renderer-specific type is public.NumberInputFieldreuses the same primitive through Arc's CommandForm adapter seam. Non-null command properties retain the established clear/non-finite-to-zero policy without a second parser or formatter.Verification
Limitations