feat: SDK multi instance support - #583
Merged
Merged
Conversation
arifBurakDemiray
marked this pull request as draft
July 22, 2026 10:23
arifBurakDemiray
marked this pull request as ready for review
July 23, 2026 13:24
Dependency security scanScanned 519 resolved dependencies — 286 buildscript, 31 published, 202 sample.
Below the HIGH threshold, but ours to upgrade (1)
Waived via allowlist (2)
82 further finding(s) in Gradle plugin internals are reported in the job summary and the Result: passed |
…ountly-sdk-android into multi-instance-support
Reconciles two independent implementations of the lifecycle dispatcher: upstream's CountlyLifecycleDispatcher (tearingDown gate + null-tolerant module snapshots + no-await stopTimer) is kept as the architecture, and this branch's unique semantics are re-applied on top of it: volatile sdkIsInitialised, synchronized onSdkConfigurationChanged (the /o/sdk callback is not routed through the dispatcher gate), onRegistrationId local snapshots, the tamper-salt init freeze, unconditional initialActivity clearing, the no-Application foreground-init warning, the setInstanceName removal, and the exact started-activity count (ported into CountlyLifecycleDispatcher, seeded atomically via addInstance) that replaces the ProcessLifecycleOwner debounce for foreground detection. This branch's LifecycleDispatcher is dropped in favour of upstream's; its three tests are rewritten against the upstream API. Verified: 1040 instrumented tests on emulator, single failure is the pre-existing locale-dependent UtilsTimeTests.testInstant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Multi Fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.