You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(probe): follow HF redirect in ingress measurement - #15
HF resolve URLs answer 302 to the CDN; curl without -L downloaded the 1040-byte redirect body, so every probe host measured ingress=0 Mbit/s and was rejected as slow. Verified from the controller: without -L: 302, 1040 bytes; with -L: 206, full range.
Summary by CodeRabbit
Bug Fixes
The Hugging Face ingress probe now follows redirects when checking ranged downloads.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: ecf73a6f-3baa-4d3a-a58f-b3ff5862d345
📥 Commits
Reviewing files that changed from the base of the PR and between 1df4832 and d6fc70b.
📒 Files selected for processing: 1
scripts/ops/probe_and_launch.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The ranged Hugging Face ingress probe now uses curl -L to follow redirects. The range, timeout, and download measurement remain unchanged.
Changes: Ingress probe
Layer / File(s)
Summary
Follow redirects scripts/ops/probe_and_launch.py
The ranged curl request now follows redirects with -L. The range, timeout, and download measurement remain unchanged.
The probe now follows Hugging Face redirects and measures the ranged download rather than the redirect response. No actionable merge-blocking risk is established; it appears ready for normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: following Hugging Face redirects during ingress probing.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HF resolve URLs answer 302 to the CDN; curl without -L downloaded the 1040-byte redirect body, so every probe host measured ingress=0 Mbit/s and was rejected as slow. Verified from the controller: without -L: 302, 1040 bytes; with -L: 206, full range.
Summary by CodeRabbit