Skip to content

cmake --install ships neither LICENSE nor NOTICE #249

Closed

Description

@SizzleUnrlsd

Summary

cmake --install installs neither LICENSE nor NOTICE. The install rules (CMakeLists.txt L464-L475 at cc811ed) install bin/cc, the libraries in lib/ and include/, and nothing else. The README's Install section lists the same contents.

Apache-2.0 sets two conditions on redistribution:

  • Section 4(a): recipients of the Work or of Derivative Works must be given a copy of the License.
  • Section 4(d): Derivative Works must include a readable copy of the attribution notices in NOTICE.

An install prefix copied or packaged as it is carries neither file.

Proposed change

  • Install LICENSE and NOTICE into share/doc/coretrace-compiler/ of the prefix, in a component of their own, so that a test can install them without building anything.
  • Add a test that installs that component into a temporary prefix and compares both files with the sources.
  • List them in the README's Install section.

Activity

  1. self-assigned this
    on Nov 7, 2026
  2. SizzleUnrlsd commented on Nov 16, 2026

    @SizzleUnrlsd
    ContributorAuthor

    Fixed by #250, merged on 2026-11-09 as bbc446e: cmake --install installs LICENSE and NOTICE in share/doc/coretrace-compiler/, in the licenses component.

    Validation, from #250: the test of the install prefix passes in the 18 CI jobs that run the test suite, at aa57784.

    #250 lists what it does not cover: the install of CoreTrace/coretrace, which fetches this project through its analyzers, and the license-compliance check, which still does not check NOTICE. The fix is in the changelog of 0.13.0, which #269 prepares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions