Repository navigation
Conversation
- CI runs inside the ros-tooling ROS images (`rostooling/setup-ros-docker`). On the plain GitHub runner the ROS environment did not reach the build and test processes: `ros2 run` could not find `rossd - Tests count topics with `ASSERT_GE`: `get_topic_names_and_types()` returns every topic in the ROS graph, which also includes topics of other nodes, so the exact count was fragile. The tests still ch - flake8 fixes in `rossdl_cmake/__init__.py`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
This PR makes ROS 2 CI reliable on Jazzy and Kilted using ROS containers and updates fragile topic-count tests.
Changes:
- Runs CI in ROS-tooling containers.
- Relaxes topic-count assertions while preserving expected-topic checks.
- Applies flake8 formatting fixes.
| File | Description |
|---|---|
rossdl_tests/rossdl_systems_test/system_b/tests/rossdl_generation_test.cpp |
Relaxes topic-count assertions. |
rossdl_tests/rossdl_systems_test/system_a/tests/rossdl_generation_test.cpp |
Relaxes topic-count assertions. |
rossdl_tests/rossdl_simple_test/tests/rossdl_generation_test.cpp |
Relaxes topic-count assertions. |
rossdl_cmake/rossdl_cmake/__init__.py |
Applies formatting fixes. |
.github/workflows/rolling.yaml |
Runs CI in ROS containers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #9 to get the CI green on ROS 2 Jazzy and Kilted.
rostooling/setup-ros-docker). On the plain GitHub runner the ROS environment did not reach the build and test processes:ros2 runcould not findrossdl_cmake, and on Kilted typesupports and libraries were missing.ASSERT_GE:get_topic_names_and_types()returns every topic in the ROS graph, which also includes topics of other nodes, so the exact count was fragile. The tests still check that each expected topic exists.rossdl_cmake/__init__.py.Checked locally in the same images: 7 packages, 120 tests, 0 failures, on Jazzy and on Kilted.
🤖 Generated with Claude Code