Repository navigation
Allow opt-in outbound networking for Docker computers - #186
Open
kevinaimonster wants to merge 1 commit into
Open
kevinaimonster wants to merge 1 commit into
kevinaimonster wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Docker computers always used
--network none, so terminal commands could not download dependencies or call HTTP APIs. AddCOMPUTER_NETWORK=bridgeas an explicit opt-in while keepingnoneas the default. Creation and attachment checks enforce the configured network; extra or mismatched networks are rejected. Existing nonroot, filesystem, capability, resource, ownership and unpublished-port checks remain in place.Expose the selected mode in agent instructions/tool descriptions and keep the terminal UI from suggesting a Desktop tab for network-enabled Docker computers. Include CA certificates in the computer image so Python and git can verify HTTPS. Document configuration, the retained-volume recreation procedure and bridge destination scope.
Verification
pnpm lint: passed (one existing Biome schema-version informational message).pnpm typecheck, worker typecheck andpnpm build:server: passed.pnpm test: 486 passed, 0 failed.Integration limits
Changing the network mode requires stopping and recreating the computer container while retaining its workspace volume; API and task workers must use the same setting. Bridge mode permits destinations reachable through Docker, including private networks, and does not enforce the browser worker's destination policy or reviewed-write gateway. No ports are published.
The terminal change is text-only; browser visual verification was unavailable because local browser automation is blocked by administrator policy. No screenshot is provided. E2B desktop cloud runtime was not exercised for this change.