Repository navigation
fix(monitors): ignore extra whitespace in contains watch text - #185
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A "contains" page watch never matches when its text has a trailing space, a double space, or a line break. The worker collapses whitespace in the page text before it searches, but it compares the watch value as typed. The new watch form sends the value untrimmed, and phone keyboards add a space after an autocompleted word. A watch for
In stockthen stays silent when the page showsIn stockorIn stock..The worker now collapses and trims whitespace in the watch value the same way it does for the page text. This also fixes watches that are already saved, because the value is normalized at check time.
Verification
pnpm lint: no errors.pnpm exec tsc --noEmit: passes.pnpm exec tsx --import ./tests/setup.ts --test tests/*.test.ts apps/mobile/test/*.test.ts: 490 tests, 490 pass.tests/monitor-contains-spacing.test.tsruns a watch through the worker with a fixture page. Without the change, 4 of its 7 cases fail (trailing space, double space, line break, and non-breaking space in the value). With the change, all 7 pass.Fixes #184