Skip to content

Fix flimsy rendering of nodes in alarm tree view #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
georgweiss wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flimsy rendering of nodes in alarm tree view #3942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions app/alarm/ui/src/main/java/org/phoebus/applications/alarm/ui/tree/AlarmTreeViewCell.java
View file
Open in desktop

@jacomago jacomago Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the commit message how the fix works?

Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,19 @@ protected void updateItem(final AlarmTreeItem<?> item, final boolean empty)
}
else
{
// To get the information to display on non-leaf nodes one will need to walk a potentially deep
// tree structure, so this is done off the UI thread.
JobManager.schedule("Get Tree Node Info", monitor -> {
TreeNodeInfo info = AlarmTreeHelper.getTreeNodeInfo(item);
Platform.runLater(() -> {
String labelText = item.getName();
label.setText(labelText);
SeverityLevel severityLevel = item.getState().severity;
disabledTimerIndicator.setText(AlarmTreeHelper.treeNodeInfoToString(info));
if(info.disabled() + info.disabledWithEnableDate() == info.leaves().size()){
label.setTextFill(Color.GRAY);
}
else{
label.setTextFill(AlarmUI.getColor(severityLevel));
}
label.setBackground(AlarmUI.getBackground(severityLevel));
image.setImage(AlarmUI.getIcon(severityLevel));
});
});
TreeNodeInfo info = AlarmTreeHelper.getTreeNodeInfo(item);
String labelText = item.getName();
label.setText(labelText);
SeverityLevel severityLevel = item.getState().severity;
disabledTimerIndicator.setText(AlarmTreeHelper.treeNodeInfoToString(info));
if(info.disabled() + info.disabledWithEnableDate() == info.leaves().size()){
label.setTextFill(Color.GRAY);
}
else{
label.setTextFill(AlarmUI.getColor(severityLevel));
}
label.setBackground(AlarmUI.getBackground(severityLevel));
image.setImage(AlarmUI.getIcon(severityLevel));
}
// Profiler showed small advantage when skipping redundant 'setGraphic' call
if (getGraphic() != content)
Expand Down
Loading