CSSTUDIO-3780 Bugfix: Boolean Button in "Push"/"Push (inverted)" mode should only write to the PV when left-clicking.#3890
Merged
Merged
Conversation
… only writes to the PV when left-clicking.
|
abrahamwolk
changed the title
jacomago
approved these changes
Jul 20, 2026
kasemir
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using a Boolean Button widget in either "Push" or in "Push (inverted)" mode, right-clicking (or, more generally, any non-primary mouse button) on the Boolean Button will write to the PV connected to the Boolean Button.
This pull request fixes this by checking that the primary mouse button (i.e., usually the left mouse button) was clicked before attempting to write to the PV connected to the Boolean Button.
Testing:
I have tested the change manually locally.
Documentation: