Skip to content

docs: drop the tier label from docs that outlived it - #32

Merged
akf66 merged 1 commit into
mainfrom
akf66/tier-language-audit
Aug 26, 2026
Merged

docs: drop the tier label from docs that outlived it#32
akf66 merged 1 commit into
mainfrom
akf66/tier-language-audit

Conversation

@akf66

@akf66 akf66 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

There is no add- or remove-label step anywhere in action.yml. Three files still described one — and the one that mattered most is the copy written into every user's repo.

What happened

#28 retired the review cascade and updated workflows/orca-code-review.yml. But the skill keeps its own copy of that workflow in assets/, because that's the file it writes into a user's repo. The example got fixed; the template users actually receive did not.

  workflows/orca-code-review.yml              (fixed by #28)
- issues: write # tier state label + clean/fallback PR comments
+ issues: write # clean/fallback PR comments

  skills/.../assets/workflow.yml              (missed — this is the one users get)
- issues: write # tier state label + clean/fallback PR comments

Fixed

File Was Now
skills/.../assets/workflow.yml # tier state label + clean/fallback PR comments matches the example
references/inputs.mdgithub-token "manages the tier label" "posts review comments, and reacts to a /orcacode-review command"
references/inputs.md — models Models | per tier Model | one
action.yml "manage the tier label" the source those two were copied from

issues: write stays

It is still required — just not for the reason the comment gave. It covers PR comments and the emoji reaction on a /orcacode-review command:

repos/$REPO/issues/comments/$COMMENT_ID/reactions

Only the justification was wrong, so only the justification changed.

Left alone, because still true

  • x-cr-prev-tier is still injected by the fact proxy. action.yml's own header says the facts and rule shape are kept deliberately, so a future size-based routing policy needs no Action change.
  • tier in the run report is still sent — but it is hardcoded standard. inputs.md now says so, otherwise a reader assumes it varies.

Five tests close the gap

The root cause is two copies of one file. So the tests compare them: comment-stripped, the example and the skill template must agree on permissions:, on: and concurrency:, and neither may mention a tier label.

Verified by reverting the fix — neither workflow copy mentions a tier label goes red.

398 passing. 1.3.1: docs-only, but skills/ ships in the npm package, so users keep receiving the wrong comment until it is published.

There is no add- or remove-label step anywhere in action.yml. Three files
still described one, and the one that mattered most is the copy written into
every user's repo.

#28 retired the review cascade and updated `workflows/orca-code-review.yml`,
but the skill keeps its own copy of that workflow in `assets/`. The example
was fixed; the template users actually receive was not.

Corrected:

  - skills/.../assets/workflow.yml — "tier state label + clean/fallback PR
    comments" -> "clean/fallback PR comments", matching the example
  - references/inputs.md — github-token no longer "manages the tier label";
    "Models | per tier" is now one model, because there is one tier
  - action.yml — the input description those two were copied from

`issues: write` stays. It is still required, just for a different reason
than the comment claimed: PR comments, and the emoji reaction on a
/orcacode-review command. Only the justification was wrong.

Left alone because they are still true: the x-cr-prev-tier fact the proxy
injects (kept deliberately so a future size-based routing policy needs no
Action change), and the `tier` field in the run report — now noted in
inputs.md as always "standard", so nobody reads it as varying.

Five tests close the gap that caused this. The example workflow and the
skill template must agree, comment-stripped, on `permissions:`, `on:` and
`concurrency:`, and neither may mention a tier label. Verified by reverting
the fix: the tier-label test goes red.
@akf66
akf66 merged commit 5fb95e9 into main Aug 26, 2026
2 checks passed
@akf66
akf66 deleted the akf66/tier-language-audit branch August 26, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant