docs: drop the tier label from docs that outlived it - #32
Merged
Conversation
There is no add- or remove-label step anywhere in action.yml. Three files still described one, and the one that mattered most is the copy written into every user's repo. #28 retired the review cascade and updated `workflows/orca-code-review.yml`, but the skill keeps its own copy of that workflow in `assets/`. The example was fixed; the template users actually receive was not. Corrected: - skills/.../assets/workflow.yml — "tier state label + clean/fallback PR comments" -> "clean/fallback PR comments", matching the example - references/inputs.md — github-token no longer "manages the tier label"; "Models | per tier" is now one model, because there is one tier - action.yml — the input description those two were copied from `issues: write` stays. It is still required, just for a different reason than the comment claimed: PR comments, and the emoji reaction on a /orcacode-review command. Only the justification was wrong. Left alone because they are still true: the x-cr-prev-tier fact the proxy injects (kept deliberately so a future size-based routing policy needs no Action change), and the `tier` field in the run report — now noted in inputs.md as always "standard", so nobody reads it as varying. Five tests close the gap that caused this. The example workflow and the skill template must agree, comment-stripped, on `permissions:`, `on:` and `concurrency:`, and neither may mention a tier label. Verified by reverting the fix: the tier-label test goes red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no add- or remove-label step anywhere in
action.yml. Three files still described one — and the one that mattered most is the copy written into every user's repo.What happened
#28 retired the review cascade and updated
workflows/orca-code-review.yml. But the skill keeps its own copy of that workflow inassets/, because that's the file it writes into a user's repo. The example got fixed; the template users actually receive did not.Fixed
skills/.../assets/workflow.yml# tier state label + clean/fallback PR commentsreferences/inputs.md—github-token/orcacode-reviewcommand"references/inputs.md— modelsModels | per tierModel | oneaction.ymlissues: writestaysIt is still required — just not for the reason the comment gave. It covers PR comments and the emoji reaction on a
/orcacode-reviewcommand:Only the justification was wrong, so only the justification changed.
Left alone, because still true
x-cr-prev-tieris still injected by the fact proxy.action.yml's own header says the facts and rule shape are kept deliberately, so a future size-based routing policy needs no Action change.tierin the run report is still sent — but it is hardcodedstandard.inputs.mdnow says so, otherwise a reader assumes it varies.Five tests close the gap
The root cause is two copies of one file. So the tests compare them: comment-stripped, the example and the skill template must agree on
permissions:,on:andconcurrency:, and neither may mention a tier label.Verified by reverting the fix —
neither workflow copy mentions a tier labelgoes red.398 passing. 1.3.1: docs-only, but
skills/ships in the npm package, so users keep receiving the wrong comment until it is published.