Skip to content

๐ŸŽจ Palette: ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ(Empty State)์˜ UI ์ผ๊ด€์„ฑ ๋ฐ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #252

Open
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-state-ux-4823324895692884004
Open

๐ŸŽจ Palette: ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ(Empty State)์˜ UI ์ผ๊ด€์„ฑ ๋ฐ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #252
seonghobae wants to merge 1 commit into
masterfrom
palette-empty-state-ux-4823324895692884004

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What: ๋นˆ ๋””๋ ‰ํ† ๋ฆฌ๋ฅผ ์•ˆ๋‚ดํ•˜๋Š” ํ…์ŠคํŠธ์— ํด๋” ์•„์ด์ฝ˜์„ ์ถ”๊ฐ€ํ•˜๊ณ  Flexbox ์ •๋ ฌ์„ ์ ์šฉํ–ˆ์œผ๋ฉฐ, ARIA role="status"๋ฅผ ๋ถ€์—ฌํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๊ธฐ์กด์—๋Š” ๋นˆ ์ƒํƒœ๊ฐ€ ์ผ๋ฐ˜ ๋ฆฌ์ŠคํŠธ ์•„์ดํ…œ๊ณผ ์‹œ๊ฐ์ ์œผ๋กœ ๋‹ค๋ฅด๊ฒŒ ๋ณด์—ฌ ์ผ๊ด€์„ฑ์ด ๋–จ์–ด์กŒ์œผ๋ฉฐ, ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ํ™˜๊ฒฝ์—์„œ๋Š” ๋‹จ์ˆœํžˆ ํ…์ŠคํŠธ๋งŒ ์ฝํ˜€ ์ƒํƒœ ๋ณ€ํ™”์— ๋Œ€ํ•œ ๋ช…ํ™•ํ•œ ์ธ์ง€๊ฐ€ ๋ถ€์กฑํ–ˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋ณ€๊ฒฝ ์ „ <li><div class="empty-dir">์ด ๋””๋ ‰ํ† ๋ฆฌ๋Š” ๋น„์–ด ์žˆ์Šต๋‹ˆ๋‹ค.</div></li> ์—์„œ ๋ณ€๊ฒฝ ํ›„ ์•„์ด์ฝ˜(&#128194;) ๋ฐ Flexbox ๋ ˆ์ด์•„์›ƒ ์ ์šฉ.
โ™ฟ Accessibility: role="status"๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๊ฐ€ ํ˜„์žฌ ํด๋”์— ํ•ญ๋ชฉ์ด ์—†์Œ์„ ์ฆ‰์‹œ ์ธ์ง€ํ•˜๋„๋ก ๊ฐœ์„ ํ–ˆ์œผ๋ฉฐ, ์žฅ์‹์šฉ ํด๋” ์•„์ด์ฝ˜์—๋Š” aria-hidden="true"๋ฅผ ์ ์šฉํ•˜์—ฌ ํ˜ผ๋™์„ ๋ฐฉ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 4823324895692884004 started by @seonghobae

Copilot AI review requested due to automatic review settings July 23, 2026 21:01
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the generated directory listing HTMLโ€™s empty-state rendering so it visually aligns with regular list items and is more accessible for screen readers.

Changes:

  • Render an empty directory entry with a folder icon and flex layout, and add role="status" for clearer announcement.
  • Update the CSS for .empty-dir to use flexbox alignment and spacing.
  • Extend the empty-directory test assertions and document the learning in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main/kotlin/html4tree/main.kt Adds flex styling for .empty-dir and updates empty-state markup to include an icon and role="status".
src/test/kotlin/html4tree/MainTest.kt Adds assertions to validate the new empty-state accessibility/markup.
.jules/palette.md Records the accessibility/UI consistency learning and action item for empty states.

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 94 to 99
val htmlContent = indexFile.readText()
assertTrue(htmlContent.contains("<html lang=\"ko\">"))
assertTrue(htmlContent.contains("์ด ๋””๋ ‰ํ† ๋ฆฌ๋Š” ๋น„์–ด ์žˆ์Šต๋‹ˆ๋‹ค."))
assertTrue(htmlContent.contains("role=\"status\""))
assertTrue(htmlContent.contains("&#128194;"))
assertTrue(htmlContent.contains("role=\"list\""))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants