⚡ Bolt: [성능 개선] process_dir 내의 불변 상수 호이스팅#249
Conversation
`process_dir` 함수 내에서 매번 재계산되던 불변 상수(`cssContent`, `styleHash`, `css`)를 클래스/파일 최상위 `private val`로 호이스팅했습니다. 이를 통해 디렉토리 크롤링 시 각 디렉토리마다 SHA-256 해시를 다시 계산하고 거대한 문자열을 할당하던 오버헤드가 제거되어 성능이 향상되고 GC 압박이 줄어듭니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes the html4tree Kotlin CLI’s HTML generation by hoisting per-directory, invariant CSS-related values out of the hot-path process_dir function so they are computed once at startup rather than on every directory render.
Changes:
- Hoisted
cssContent,styleHash(SHA-256), andcssfrom insideprocess_dirto top-levelprivate vals for reuse across calls. - Updated
.jules/bolt.mdwith a new performance “learning/action” entry documenting the constant-hoisting optimization.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/html4tree/main.kt | Hoists CSS/CSP hash computation out of process_dir to reduce repeated hashing and string allocations. |
| .jules/bolt.md | Documents the performance rationale and action item for avoiding repeated expensive computations in hot paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private val css = """ | ||
| <style> | ||
| ${cssContent} </style> | ||
| """ |
💡 What:
process_dir함수 내에서 매번 계산되던 불변 상수(cssContent,styleHash,css)를 최상위private val로 호이스팅했습니다.🎯 Why: 자주 호출되는 함수 내부에서 무거운 SHA-256 연산과 문자열 연결을 반복하면 불필요한 성능 저하와 가비지 컬렉션(GC) 압박이 발생합니다.
📊 Impact: 디렉토리 처리 속도 향상 및 메모리 할당 횟수 대폭 감소를 기대합니다.
🔬 Measurement: 단위 테스트를 실행하여 정상 작동 및 100% 테스트 커버리지 유지 여부를 확인합니다.
PR created automatically by Jules for task 5081483986542290953 started by @seonghobae