Skip to content

๐ŸŽจ Palette: ์•„์ด์ฝ˜ ์ „์šฉ ๋ฒ„ํŠผ์— Tooltip(title) ์ถ”๊ฐ€#693

Open
seonghobae wants to merge 3 commits into
developfrom
feat/add-titles-to-icon-buttons-18216407672799755199
Open

๐ŸŽจ Palette: ์•„์ด์ฝ˜ ์ „์šฉ ๋ฒ„ํŠผ์— Tooltip(title) ์ถ”๊ฐ€#693
seonghobae wants to merge 3 commits into
developfrom
feat/add-titles-to-icon-buttons-18216407672799755199

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What:

  • ScoreViewer ๋ฐ ScoreView ๋‚ด์˜ ์•„์ด์ฝ˜ ์ „์šฉ ๋ฒ„ํŠผ(Zoom In/Out, Prev/Next Page, Remove ๋“ฑ)์— aria-label๊ณผ ์ผ์น˜ํ•˜๋Š” title ์†์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • eslint.config.js ์‹คํ–‰ ์‹œ ๋ฐœ์ƒํ•˜๋Š” @eslint/js ๋ชจ๋“ˆ ์ฐธ์กฐ ์˜ค๋ฅ˜๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด ๊ฐœ๋ฐœ ์˜์กด์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ Why:

  • ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋Š” aria-label์„ ํ†ตํ•ด ๋ฒ„ํŠผ์˜ ์—ญํ• ์„ ์•Œ ์ˆ˜ ์žˆ์ง€๋งŒ, ์‹œ๋ ฅ์ด ์žˆ๋Š” ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž๋Š” ์•„์ด์ฝ˜๋งŒ์œผ๋กœ๋Š” ๋ฒ„ํŠผ์˜ ๊ธฐ๋Šฅ์„ ์ •ํ™•ํžˆ ์œ ์ถ”ํ•˜๊ธฐ ์–ด๋ ค์šธ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. title ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜๋ฉด ๋„ค์ดํ‹ฐ๋ธŒ ๋ธŒ๋ผ์šฐ์ € ํˆดํŒ์ด ์ œ๊ณต๋˜์–ด ์‚ฌ์šฉ์„ฑ์ด ๊ฐœ์„ ๋ฉ๋‹ˆ๋‹ค.

โ™ฟ Accessibility:

  • ๋งˆ์šฐ์Šค ํ˜ธ๋ฒ„ ์‹œ ๋ฒ„ํŠผ์˜ ๋ชฉ์ ์„ ๋ช…ํ™•ํžˆ ์ „๋‹ฌํ•˜์—ฌ ์‹œ๊ฐ์  ์ธ์ง€ ์ ‘๊ทผ์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ Note:

  • .jules/palette.md์— ๊ด€๋ จ๋œ UX/a11y ํ•™์Šต ๊ธฐ๋ก์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 18216407672799755199 started by @seonghobae

- ScoreViewer์™€ ScoreView์˜ ์•„์ด์ฝ˜ ์ „์šฉ ๋ฒ„ํŠผ์— aria-label๊ณผ ๋™์ผํ•œ title ์†์„ฑ ์ถ”๊ฐ€ (๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž ์ ‘๊ทผ์„ฑ ํ–ฅ์ƒ)
- .jules/palette.md์— ๊ด€๋ จ๋œ UX ํ•™์Šต ๋‚ด์šฉ ๊ธฐ๋ก
- ์›Œํฌ์ŠคํŽ˜์ด์Šค lint ์˜ค๋ฅ˜ ํ•ด๊ฒฐ์„ ์œ„ํ•ด @eslint/js ์˜์กด์„ฑ ์ถ”๊ฐ€
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 24, 2026 03:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the score-viewing UIโ€™s usability by adding native hover tooltips (title) to icon-only controls, aligning the tooltip text with existing aria-label values.

Changes:

  • Added title attributes to zoom and page navigation icon buttons in ScoreViewer.
  • Added a title attribute to the icon-only โ€œremove attachmentโ€ button in ScoreView.
  • Documented the tooltip learning in .jules/palette.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
apps/desktop/src/features/score/ScoreViewer.tsx Adds title tooltips to icon-only zoom and prev/next page buttons.
apps/desktop/src/features/score/ScoreView.tsx Adds a title tooltip to the icon-only remove button in the attachment list.
.jules/palette.md Adds a UX/a11y learning note about tooltips for icon-only buttons.
Comments suppressed due to low confidence (1)

apps/desktop/src/features/score/ScoreViewer.tsx:313

  • title tooltips do not display on natively disabled buttons, so the tooltip will be missing on the last page (when pageNumber >= pageCount). If you want the tooltip to be available even in the disabled state, prefer aria-disabled and guard the click handler instead of using the disabled attribute.
            className="size-14"
            aria-label={t("scoreViewerNextPage")}
            title={t("scoreViewerNextPage")}
            disabled={pageNumber >= pageCount}
            onClick={goToNextPage}

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 296 to 299
aria-label={t("scoreViewerPrevPage")}
title={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
Comment thread .jules/palette.md
Comment on lines +4 to +6
## 2024-07-24 - Tooltips for icon-only buttons
**Learning:** Icon-only buttons (like those using `lucide-react` icons) with an `aria-label` are accessible to screen readers, but mouse/sighted users miss out on this context, reducing usability.
**Action:** Always add a `title` attribute matching the `aria-label` to icon-only buttons to provide native browser tooltips on hover.
- upgrade setuptools to 83.0.0 in services/analysis-engine to fix CVE-2024-59890 (via uv)
- upgrade brace-expansion in node_modules via npm audit fix
Copilot AI review requested due to automatic review settings July 24, 2026 04:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

apps/desktop/src/features/score/ScoreViewer.tsx:299

  • disabled ๋ฒ„ํŠผ์—์„œ๋Š” ๋ธŒ๋ผ์šฐ์ €๊ฐ€ hover/tooltip ์ด๋ฒคํŠธ๋ฅผ ์ฒ˜๋ฆฌํ•˜์ง€ ์•Š์•„ title ํˆดํŒ์ด ํ‘œ์‹œ๋˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. ํŽ˜์ด์ง€ ๊ฒฝ๊ณ„์—์„œ Prev ๋ฒ„ํŠผ์ด disabled๊ฐ€ ๋˜๋ฏ€๋กœ, ํ˜„์žฌ ๋ณ€๊ฒฝ์˜ ๋ชฉ์ (๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž์—๊ฒŒ ํˆดํŒ ์ œ๊ณต)์ด ๋‹ฌ์„ฑ๋˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. disabled ์ƒํƒœ์—์„œ๋„ ํˆดํŒ์ด ๋ณด์ด๋„๋ก disabled ์ƒํƒœ์—์„œ๋งŒ pointer-events๋ฅผ ๋ถ€๋ชจ๋กœ ๋„˜๊ธฐ๋Š” ๋ž˜ํผ(span[title])๋ฅผ ์ถ”๊ฐ€ํ•˜๊ฑฐ๋‚˜, aria-disabled ํŒจํ„ด์œผ๋กœ ์ „ํ™˜ํ•ด ์ฃผ์„ธ์š”.
            aria-label={t("scoreViewerPrevPage")}
            title={t("scoreViewerPrevPage")}
            disabled={pageNumber <= 1}
            onClick={goToPreviousPage}

.jules/palette.md:6

  • ์ด ๊ฐ€์ด๋“œ๋Š” title ์ถ”๊ฐ€๋งŒ ๊ฐ•์กฐํ•˜๊ณ  ์žˆ๋Š”๋ฐ, ๊ฐ™์€ ๋ฌธ์„œ ์ƒ๋‹จ์˜ ํ•™์Šต์ฒ˜๋Ÿผ disabled ์ƒํƒœ์—์„œ๋Š” ํˆดํŒ์ด ํ‘œ์‹œ๋˜์ง€ ์•Š์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. "์•„์ด์ฝ˜ ์ „์šฉ ๋ฒ„ํŠผ์— title" ์›์น™์„ ์ ์šฉํ•  ๋•Œ, disabled ๊ฐ€๋Šฅ ๋ฒ„ํŠผ์€ aria-disabled/๋ž˜ํผ(span[title]) ๊ฐ™์€ ์˜ˆ์™ธ ํŒจํ„ด์ด ํ•„์š”ํ•˜๋‹ค๋Š” ์ ์„ ํ•จ๊ป˜ ๋ช…์‹œํ•˜๋Š” ๊ฒŒ ์ข‹์Šต๋‹ˆ๋‹ค.
## 2024-07-24 - Tooltips for icon-only buttons
**Learning:** Icon-only buttons (like those using `lucide-react` icons) with an `aria-label` are accessible to screen readers, but mouse/sighted users miss out on this context, reducing usability.
**Action:** Always add a `title` attribute matching the `aria-label` to icon-only buttons to provide native browser tooltips on hover.

Comment on lines 309 to 313
className="size-14"
aria-label={t("scoreViewerNextPage")}
title={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
Comment on lines 198 to 202
onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
disabled={!projectId}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
title={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
- upgrade setuptools to >=83.0.0 in services/analysis-engine to fix CVE-2024-59890 (via uv)
- upgrade brace-expansion in node_modules via npm audit fix
Copilot AI review requested due to automatic review settings July 24, 2026 04:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

apps/desktop/src/features/score/ScoreViewer.tsx:300

  • These buttons set a title, but because they use the native disabled attribute, the element wonโ€™t receive hover events in most browsersโ€”so the tooltip wonโ€™t appear exactly when the button is disabled (arguably the most important time to explain the control). Consider using aria-disabled plus a guarded/conditional onClick instead, so the tooltip still works while clicks remain blocked.
            aria-label={t("scoreViewerPrevPage")}
            title={t("scoreViewerPrevPage")}
            disabled={pageNumber <= 1}
            onClick={goToPreviousPage}
          >

apps/desktop/src/features/score/ScoreViewer.tsx:314

  • Same issue as the previous button: using the native disabled attribute prevents hover/pointer events, so the title tooltip wonโ€™t show while disabled. Using aria-disabled and guarding the click keeps the tooltip available without allowing interaction.
            aria-label={t("scoreViewerNextPage")}
            title={t("scoreViewerNextPage")}
            disabled={pageNumber >= pageCount}
            onClick={goToNextPage}
          >

apps/desktop/src/features/score/ScoreView.tsx:202

  • This remove button gets a title, but it is also disabled when !projectId, which will suppress hover events and prevent the tooltip from showing. Switching to aria-disabled (and relying on the already-conditional onClick) keeps the control non-functional while still allowing the tooltip to explain the icon.
                      size="icon"
                      onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
                      disabled={!projectId}
                      aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
                      title={`${t("scoreRemove")}: ${attachment.fileName}`}
                      className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"

Comment on lines 14 to 18
"numpy>=1.26",
"setuptools>=83.0.0",
"soundfile>=0.13.1",
"urllib3>=2.7.0",
"urllib3>=2.7.0",
"yt-dlp>=2026.6.9",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants