Repository navigation
refactor(demos): framing test helpers are split / join, like the pipes - #134
Merged
Merged
Conversation
GrpcFramesSpec still called its helpers `decode` and `framed` after the pipes became `splitFrames` / `joinFrames`. In the demo's benchmarks `decode` means decoding a whole `Issue` (the baseline judge), so a framing helper by that name read as the same thing. - GrpcFramesSpec: `decode` → `split`, `framed` → `join`. `join` moves to the companion, next to `pieces`, and PipelineSpec frames its upstream with it, as StreamBench does with `joinFrames`. - GrpcFrames.Malformed's doc names `splitFrames` instead of "this decoder". - Cookbook, stream triage demo: the GrpcFramesSpec row says the messages are joined into frames and split back whole, and the framing fence's comments line up again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JG5LJsPA524HKbSMvjStrv
Contributor
|
🚀 Cloudflare Pages preview for https://a6aaca79.cats-eo-docs.pages.dev Branch alias: https://ccr-1ec1a317-uds4rn.cats-eo-docs.pages.dev Built from commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #133. The gRPC framing pipes were renamed
splitFrames/joinFramesthere, butGrpcFramesSpec's helpers kept the old names,decodeandframed. In the demo's benchmarksdecodemeans decoding a wholeIssue(the baseline judge), so a framing helper with that name read as the same thing.GrpcFramesSpec:decode→split,framed→join.joinmoves to the companion, next topieces.PipelineSpecnow frames its upstream with it, the wayStreamBenchdoes withjoinFrames.GrpcFrames.Malformed: its doc namessplitFramesinstead of "this decoder".GrpcFramesSpecrow now says messages are joined into frames and split back whole (it said "decode back whole");The benchmarks keep
decodefor the full-decode judge, which is what the recipe's benchmark tables call it.Checked locally:
demoGrpcFilter/testpasses (35 tests),demoGrpcFilterBench/Jmh/compilesucceeds, and the scalafmt and scalafix checks are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01JG5LJsPA524HKbSMvjStrv
Generated by Claude Code