Skip to content

refactor(demos): framing test helpers are split / join, like the pipes - #134

Merged
kryptt merged 1 commit into
mainfrom
ccr-1ec1a317-uds4rn
Oct 16, 2026
Merged

kryptt merged 1 commit into
mainfrom
ccr-1ec1a317-uds4rn

Conversation

@kryptt

@kryptt kryptt commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #133. The gRPC framing pipes were renamed splitFrames / joinFrames there, but GrpcFramesSpec's helpers kept the old names, decode and framed. In the demo's benchmarks decode means decoding a whole Issue (the baseline judge), so a framing helper with that name read as the same thing.

  • GrpcFramesSpec:
    • decode → split, framed → join.
    • join moves to the companion, next to pieces. PipelineSpec now frames its upstream with it, the way StreamBench does with joinFrames.
  • GrpcFrames.Malformed: its doc names splitFrames instead of "this decoder".
  • Cookbook, "Allocation-free stream triage demo":
    • the GrpcFramesSpec row now says messages are joined into frames and split back whole (it said "decode back whole");
    • the comments in the framing code block line up again.

The benchmarks keep decode for the full-decode judge, which is what the recipe's benchmark tables call it.

Checked locally: demoGrpcFilter/test passes (35 tests), demoGrpcFilterBench/Jmh/compile succeeds, and the scalafmt and scalafix checks are clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JG5LJsPA524HKbSMvjStrv


Generated by Claude Code

GrpcFramesSpec still called its helpers `decode` and `framed` after the
pipes became `splitFrames` / `joinFrames`. In the demo's benchmarks
`decode` means decoding a whole `Issue` (the baseline judge), so a
framing helper by that name read as the same thing.

- GrpcFramesSpec: `decode` → `split`, `framed` → `join`. `join` moves
  to the companion, next to `pieces`, and PipelineSpec frames its
  upstream with it, as StreamBench does with `joinFrames`.
- GrpcFrames.Malformed's doc names `splitFrames` instead of "this
  decoder".
- Cookbook, stream triage demo: the GrpcFramesSpec row says the
  messages are joined into frames and split back whole, and the
  framing fence's comments line up again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JG5LJsPA524HKbSMvjStrv
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cloudflare Pages preview for ccr-1ec1a317-uds4rn is live:

https://a6aaca79.cats-eo-docs.pages.dev

Branch alias: https://ccr-1ec1a317-uds4rn.cats-eo-docs.pages.dev

Built from commit 5466ff7a53ff55e6db616ef91c6b8cd70ac3fb9e · updated on every push.

@kryptt
kryptt merged commit 611ee84 into main Oct 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants