feat(chat): add DeleteMessage gRPC RPC - #1621
Merged
Merged
Conversation
Share delete with a helper so callers can remove a message and still broadcast message-deleted.
2 tasks
Contributor
|
@JohnChantz CI check failed on this head ( https://app.snyk.io/org/kkopanidis/pr-checks/1f46beda-fe28-4a24-881c-32f4bdf310f5 |
ChrisPdgn
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chat.DeleteMessage, matchingEditMessage, so other modules can delete a message and still emitmessage-deletedon the chat namespace.deleteChatMessage: sender check,allowMessageDelete,auditModehard-delete vsdeleted: true, socket push, and bus publish.Test plan
modules/chatunit tests for hard-delete, audit-mode soft-delete, missing message, non-sender, andallowMessageDelete: false@conduitplatform/grpc-sdkand@conduitplatform/module-tools0.16.31from thev0.16.xbackport before Viz main-service depends ondeleteMessage