fix(settings): stop create-admin sheet crash after save - #335
Draft
JohnChantz wants to merge 1 commit into
Draft
JohnChantz wants to merge 1 commit into
JohnChantz wants to merge 1 commit into
Conversation
Creating an admin succeeded, then closing the sheet re-ran a dirty-form effect and looped AlertProvider. Keep inputs controlled and confirm discard from onOpenChange instead.
JohnChantz
force-pushed
the
cursor/fix-create-admin-user-ec01
branch
from
September 25, 2026 14:37
26dfeaf to
20a60b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
masterbranchfix #xxx, where "xxx" is the issue number)What was broken
Clicking Create on Settings → Admin Users → "Create new admin user" saved the admin, then crashed the page with a Next.js overlay (
Maximum update depth exceededinAlertProvider).Cause
postNewAdminUsersucceeded. Closing the sheet ran auseEffectthat treated the dirty form as an unsaved discard, calledaddAlerton every render (unstablesetOpenin the effect deps), and looped. Inputs also had nodefaultValues, so they flipped between uncontrolled and controlled.Fix
onOpenChangeinstead of an effectErrors so Server Actions can serialize themAlertProvidertoisOpeninstead of the undefinedopenidentifierTest plan
AddAdminSheetcontrolled defaults and successful create without the unsaved-changes dialogwithAdminApiErrorserializes axios-like failures and rethrows Next redirectsuiadmin_fixed, confirm success toast, table row, and no overlaycreate_admin_user_success.mp4
Other information:
Targets
ui-rewrite.