Skip to content

Add Kokkos version with dependent Cabana implementation - #88

Draft
streeve wants to merge 6 commits into
CompPhysVienna:masterfrom
streeve:kokkos
Draft

Add Kokkos version with dependent Cabana implementation#88
streeve wants to merge 6 commits into
CompPhysVienna:masterfrom
streeve:kokkos

Conversation

@streeve

@streeve streeve commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Convert standalone Cabana implementation to Kokkos version with dependent Cabana version, where only functions with neighbor loops differ significantly

LAMMPS interface is still in progress, as is full testing of the Kokkos only codepath

@streeve
streeve marked this pull request as draft February 25, 2021 18:07
@streeve

streeve commented Feb 25, 2021

Copy link
Copy Markdown
Contributor Author

One thing missing here is that the Cabana dependency on the Kokkos version should be included in the makefile (currently a user would need to include both ModeKokkos.h and ModeCabana.h explicitly

@singraber

Copy link
Copy Markdown
Member

Thanks a lot for keeping me updated, I am looking forward to test it :-)!

@singraber singraber added enhancement New feature or request interface Concerns the interface to third-party software labels Mar 9, 2021
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.76%. Comparing base (2f05836) to head (0283d5e).
⚠️ Report is 253 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   71.71%   71.76%   +0.05%     
==========================================
  Files         129      129              
  Lines       13954    13981      +27     
==========================================
+ Hits        10007    10034      +27     
  Misses       3947     3947              
Flag Coverage Δ
cpp 74.55% <ø> (+0.02%) ⬆️
python 71.76% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request interface Concerns the interface to third-party software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants